Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MpRTP modifications on OpenWebRTC #491

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

balazskreith
Copy link

Hi,

I would like to automatically merge from the master branch to keep this branch updated.

@stefanalund
Copy link
Contributor

@superdump @stefhak @zaheduzzaman how do we handle this one?

@superdump
Copy link
Contributor

@balazskreith - Is this ready for review? Does it work? Does it break any standard use cases?

@balazskreith
Copy link
Author

I need to finish the congestion control test implemented in the plugin,
then I assemble it to the openwebrtc and then we can start the review
process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain [email protected] wrote:

@balazskreith https://github.com/balazskreith - Is this ready for
review? Does it work? Does it break any standard use cases?


Reply to this email directly or view it on GitHub
#491 (comment)
.

@IngJohEricsson
Copy link

Hi
Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin,
then I assemble it to the openwebrtc and then we can start the review
process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for
review? Does it work? Does it break any standard use cases?


Reply to this email directly or view it on GitHub
#491 (comment)
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/491#issuecomment-174190101.

@balazskreith
Copy link
Author

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson [email protected]
wrote:

Hi
Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]
mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin,
then I assemble it to the openwebrtc and then we can start the review
process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]
mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for
review? Does it work? Does it break any standard use cases?


Reply to this email directly or view it on GitHub
<
#491 (comment)

.


Reply to this email directly or view it on GitHub<
#491 (comment)

.


Reply to this email directly or view it on GitHub
#491 (comment)
.

@IngJohEricsson
Copy link

Interesting
And very interested to know your findings and if you encounter issues with SCReAM
Ingemar

Skickat från min iPhone

23 jan. 2016 kl. 22:30 skrev balazskreith <[email protected]mailto:[email protected]>:

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson <[email protected]mailto:[email protected]>
wrote:

Hi
Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]mailto:[email protected]
mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin,
then I assemble it to the openwebrtc and then we can start the review
process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]mailto:[email protected]
mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for
review? Does it work? Does it break any standard use cases?


Reply to this email directly or view it on GitHub
<
#491 (comment)

.


Reply to this email directly or view it on GitHub<
#491 (comment)

.


Reply to this email directly or view it on GitHub
#491 (comment)
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/491#issuecomment-174224161.

…ach and detach subflows dynamically. Change test-send-receive test in order to contain mprtp join and detach possibility
@balazskreith
Copy link
Author

I updated openwebrtc and cerbero at https://github.com/multipath-rtp.

You can build it by git clone https://github.com/multipath-rtp/cerbero.

cerbero is altered by using gst-mprtp and
https://github.com/multipath-rtp/openwebrtc recipe to build.

multipath-rtp/openwebrtc only differs from EricssonResearch/openwebrtc by
its transport/owr_transport_agent., which contains the mprtp plugin and
providing interfaces to join and detach subflows and the
tests/test_send_receive, which join subflow while running the elements.

Its only the basic, gst-mprtp can control number of subflow and distribute
a traffic a given ratio determined by the application uses it (i.e.:
openwebrtc). There are tons of possibility and I also know there are tons
of issues I have if you will start it reviewing.
Please notify me if you tried it, or you have questions.

Balázs

On 24 January 2016 at 10:38, IngJohEricsson [email protected]
wrote:

Interesting
And very interested to know your findings and if you encounter issues with
SCReAM
Ingemar

Skickat från min iPhone

23 jan. 2016 kl. 22:30 skrev balazskreith <[email protected]
mailto:[email protected]>:

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson <[email protected]
mailto:[email protected]>
wrote:

Hi
Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]
mailto:[email protected]
mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin,
then I assemble it to the openwebrtc and then we can start the review
process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]
mailto:[email protected]
mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for
review? Does it work? Does it break any standard use cases?


Reply to this email directly or view it on GitHub
<

#491 (comment)

.


Reply to this email directly or view it on GitHub<

#491 (comment)

.


Reply to this email directly or view it on GitHub
<
#491 (comment)

.


Reply to this email directly or view it on GitHub<
#491 (comment)

.


Reply to this email directly or view it on GitHub
#491 (comment)
.

@balazskreith
Copy link
Author

I forgot to add that I am planning that longer mail to send you on next
week.

On 13 February 2016 at 20:36, Balázs Kreith [email protected] wrote:

I updated openwebrtc and cerbero at https://github.com/multipath-rtp.

You can build it by git clone https://github.com/multipath-rtp/cerbero.

cerbero is altered by using gst-mprtp and
https://github.com/multipath-rtp/openwebrtc recipe to build.

multipath-rtp/openwebrtc only differs from EricssonResearch/openwebrtc by
its transport/owr_transport_agent., which contains the mprtp plugin and
providing interfaces to join and detach subflows and the
tests/test_send_receive, which join subflow while running the elements.

Its only the basic, gst-mprtp can control number of subflow and distribute
a traffic a given ratio determined by the application uses it (i.e.:
openwebrtc). There are tons of possibility and I also know there are tons
of issues I have if you will start it reviewing.
Please notify me if you tried it, or you have questions.

Balázs

On 24 January 2016 at 10:38, IngJohEricsson [email protected]
wrote:

Interesting
And very interested to know your findings and if you encounter issues
with SCReAM
Ingemar

Skickat från min iPhone

23 jan. 2016 kl. 22:30 skrev balazskreith <[email protected]
mailto:[email protected]>:

I try a combination of ScREAM and adaptive FEC.

On 23 January 2016 at 17:09, IngJohEricsson <[email protected]
mailto:[email protected]>
wrote:

Hi
Curious. What kind of congestion control is it?

Skickat från min iPhone

23 jan. 2016 kl. 15:29 skrev balazskreith <[email protected]
mailto:[email protected]
mailto:[email protected]>:

I need to finish the congestion control test implemented in the plugin,
then I assemble it to the openwebrtc and then we can start the review
process. Write to all of you soon.

On 23 January 2016 at 08:00, Robert Swain <[email protected]
mailto:[email protected]
mailto:[email protected]> wrote:

@balazskreith https://github.com/balazskreith - Is this ready for
review? Does it work? Does it break any standard use cases?


Reply to this email directly or view it on GitHub
<

#491 (comment)

.


Reply to this email directly or view it on GitHub<

#491 (comment)

.


Reply to this email directly or view it on GitHub
<
#491 (comment)

.


Reply to this email directly or view it on GitHub<
#491 (comment)

.


Reply to this email directly or view it on GitHub
#491 (comment)
.

@Zubnix
Copy link
Contributor

Zubnix commented Feb 21, 2017

This is open for over a year now. What's the current status of this PR? What's keeping it from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants