Remove obsolete files

README.md

@@ -4,7 +4,7 @@
 
 ## Overview
 
-A library of SQL best practices implemented as more than 150 [database code analysis rules](https://learn.microsoft.com/sql/tools/sql-database-projects/concepts/sql-code-analysis/sql-code-analysis?view=sql-server-ver15&pivots=sq1-visual-studio-sdk#sql-project-file-sample-and-syntax) checked at build.
+A library of SQL best practices implemented as more than 120 [database code analysis rules](https://learn.microsoft.com/sql/tools/sql-database-projects/concepts/sql-code-analysis/sql-code-analysis?view=sql-server-ver15&pivots=sq1-visual-studio-sdk#sql-project-file-sample-and-syntax) checked at build.
 
 The rules can be added as NuGet packages to SQL projects based on either [MSBuild.Sdk.SqlProj](https://github.com/rr-wfm/MSBuild.Sdk.SqlProj) or [Microsoft.Build.Sql](https://github.com/microsoft/DacFx)
 

SqlServer.Rules.Generator/SqlServer.Rules.Generator.csproj

@@ -1,11 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <OutputType>Exe</OutputType>
-    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>
   <PropertyGroup>
     <SatelliteResourceLanguages>en-US</SatelliteResourceLanguages>
+    <NeutralLanguage>en-US</NeutralLanguage>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\SqlServer.Rules.Report\SqlServer.Rules.Report.csproj" />

SqlServer.Rules.Report/Information.cs

@@ -1,11 +1,12 @@
-using System;
+using System;
 
 namespace SqlServer.Rules.Report;
 
 [Serializable]
 public class Information
 {
     public string Solution { get; set; }
+
     public DateTime ReportDate { get; set; } = DateTime.Now;
 
     public InspectionScope InspectionScope { get; set; }

SqlServer.Rules.Report/Report.cs → SqlServer.Rules.Report/ReportEntity.cs

@@ -1,26 +1,30 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Xml.Serialization;
 
 namespace SqlServer.Rules.Report;
 
 [Serializable]
-public class Report
+public class ReportEntity
 {
     [XmlAttribute]
     public string ToolsVersion { get; set; }
 
     public Information Information { get; set; }
+
+#pragma warning disable CA2227 // Collection properties should be read only
     public List<IssueType> IssueTypes { get; set; }
+
     public List<RulesProject> Issues { get; set; }
 
-    public Report()
+#pragma warning restore CA2227 // Collection properties should be read only
+    public ReportEntity()
     {
     }
 
-    public Report(string solutionName, List<IssueType> issueTypes, string projectName, List<Issue> problems)
+    public ReportEntity(string solutionName, List<IssueType> issueTypes, string projectName, List<Issue> problems)
     {
-        ToolsVersion = typeof(Report).Assembly.GetName().Version.ToString();
+        ToolsVersion = typeof(ReportEntity).Assembly.GetName().Version.ToString();
         Information = new Information { Solution = $"{solutionName}.sln" };
         IssueTypes = issueTypes;
         Issues =

SqlServer.Rules.Report/ReportFactory.cs

@@ -83,7 +83,7 @@ public void Create(ReportRequest request)
         SendNotification($"Running rules complete, elapsed: {sw.Elapsed.ToString(@"hh\:mm\:ss", CultureInfo.InvariantCulture)}");
 
         // create report object
-        var report = new Report(
+        var report = new ReportEntity(
             request.Solution,
             GetIssueTypes(service.GetRules(), request.SuppressIssueTypes).ToList(),
             request.FileName,
@@ -192,9 +192,9 @@ private static IEnumerable<Issue> GetProblems(IEnumerable<SqlRuleProblem> proble
                };
     }
 
-    private static void SerializeReport(Report report, string outputPath)
+    private static void SerializeReport(ReportEntity report, string outputPath)
     {
-        var serializer = new XmlSerializer(typeof(Report));
+        var serializer = new XmlSerializer(typeof(ReportEntity));
         var ns = new XmlSerializerNamespaces([new XmlQualifiedName(string.Empty, string.Empty)]);
         var xmlSettings = new XmlWriterSettings
         {
@@ -209,7 +209,7 @@ private static void SerializeReport(Report report, string outputPath)
         }
     }
 
-    private static void SerializeReportToCSV(Report report, string outputPath)
+    private static void SerializeReportToCSV(ReportEntity report, string outputPath)
     {
         var sb = new StringBuilder();
         sb.AppendLine("Issue Id,Message,Line/Offset,File Name");

SqlServer.Rules.Report/ReportRequest.cs

@@ -7,6 +7,7 @@ namespace SqlServer.Rules.Report;
 public class ReportRequest
 {
     public string Solution { get; set; }
+
     public string InputPath { get; set; }
 
     public string SolutionName
@@ -17,6 +18,7 @@ public string SolutionName
     public string OutputDirectory { get; set; } = string.Empty;
 
     private string outputFileName;
+
     public string OutputFileName
     {
         get

SqlServer.Rules.Report/RulesProject.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Xml.Serialization;
 
@@ -12,5 +12,7 @@ public class RulesProject
     public string Name { get; set; }
 
     [XmlElement(ElementName = "Issue")]
+#pragma warning disable CA2227 // Collection properties should be read only
     public List<Issue> Issues { get; set; }
+#pragma warning restore CA2227 // Collection properties should be read only
 }

SqlServer.Rules.Report/SqlServer.Rules.Report.csproj

@@ -1,11 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <OutputType>Library</OutputType>
-    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>
   <PropertyGroup>
     <SatelliteResourceLanguages>en-US</SatelliteResourceLanguages>
+    <NeutralLanguage>en-US</NeutralLanguage>
   </PropertyGroup>
   <ItemGroup>
     <Content Include="Resources\RulesTransform.xslt" />

SqlServer.Rules.Test/Docs/DocsGenerator.cs

@@ -123,9 +123,7 @@ private static void GenerateRuleMarkdown(TypeComments comments, List<string> ele
 
         if (comments?.FullCommentText != null)
         {
-            var fullXml = "<comments>" + comments.FullCommentText.Trim() + "</comments>";
-            var fullComments = new XmlDocument();
-            fullComments.LoadXml(fullXml);
+            var fullComments = LoadXml(comments);
 
             isIgnorable = fullComments.SelectSingleNode("comments/IsIgnorable")?.InnerText ?? "false";
             friendlyName = fullComments.SelectSingleNode("comments/FriendlyName")?.InnerText;
@@ -271,9 +269,7 @@ private static void GenerateTocMarkdown(List<Type> sqlServerRules, List<string>
 
                 if (comments?.FullCommentText != null)
                 {
-                    var fullXml = "<comments>" + comments.FullCommentText.Trim() + "</comments>";
-                    var fullComments = new XmlDocument();
-                    fullComments.LoadXml(fullXml);
+                    var fullComments = LoadXml(comments);
 
                     isIgnorable = fullComments.SelectSingleNode("comments/IsIgnorable")?.InnerText ?? "No";
                     friendlyName = fullComments.SelectSingleNode("comments/FriendlyName")?.InnerText;
@@ -315,6 +311,14 @@ private static void GenerateTocMarkdown(List<Type> sqlServerRules, List<string>
         File.WriteAllText(Path.Combine(docsFolder, "table_of_contents.md"), stringBuilder.ToString(), Encoding.UTF8);
     }
 
+    private static XmlDocument LoadXml(TypeComments comments)
+    {
+        var fullXml = "<comments>" + comments.FullCommentText.Trim() + "</comments>";
+        var fullComments = new XmlDocument();
+        fullComments.LoadXml(fullXml);
+        return fullComments;
+    }
+
     private static Dictionary<string, List<string>> CollectRuleScripts(string rulesScriptFolder)
     {
         var ruleScripts = new Dictionary<string, List<string>>();