Support multiple namespaces in QueryablePayload::transaction_with_proof
#1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1010
Description
Currently the
QueryablePayload::transaction_with_proof
is broken as it does not support more than one namespace with namespace id:VmId(0)
.This PR fixes broken code such that both proving and verification can be done for transactions in all namespaces of the block.
Other benefits
Methods like
get_tx_table_len
andget_tx_table_len_proof
inpayload.rs
were designed when only a single tx-table existed (no namespaces). These are now removed (no other methods depended on them) and the new implementation instead makes use of theTxTable
insidetables.rs
.Considerations
A caching mechanism was designed when we only had a single tx-table (no namespaces). This could be revisited to regain some efficiency from re-using the proofs generated fx for tx-table lengths.
espresso-sequencer/sequencer/src/block/payload.rs
Lines 75 to 83 in 6494449