remove V1 version variant from the binary #2238
Conversation
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
tbro
as code owners
imabdulbasit
changed the title
imabdulbasit
force-pushed
the
ab/rm-v1
branch
from
ca613bf to
00fd49d
Compare
imabdulbasit
force-pushed
the
ab/rm-v1
branch
from
9a25b97 to
5ef9163
Compare
.github/workflows/test.yml
Outdated
| @@ -77,8 +77,7 @@ jobs: | |||
| - name: Test Integration | |||
| env: | |||
| NEXTEST_PROFILE: integration | |||
| INTEGRATION_TEST_SEQUENCER_VERSION: 02 | |||
| run: cargo nextest run --locked --release --all-features --verbose --nocapture | |||
| run: cargo nextest run --locked --release --all-features --verbose --nocapture --test integration smoke | |||
There was a problem hiding this comment.
What exactly does this do now?
There was a problem hiding this comment.
so the there are two tests inside integration: smoke and upgrade test. This one just runs smoke test for V2 version.
There was a problem hiding this comment.
as we are not doing any upgrade for the native demo now
There was a problem hiding this comment.
test.yaml changed a lot last week. In the new version you probably only need to remove the 02 from matrix.version
| cargo nextest run --archive-file nextest-archive.tar.zst --verbose --no-fail-fast \ | ||
| --workspace-remap $PWD | ||
| cargo nextest run --archive-file nextest-archive.tar.zst --verbose --no-fail-fast \ | ||
| --workspace-remap $PWD $(if [ "${{ matrix.version }}" == "2" ]; then echo " smoke"; fi) |
There was a problem hiding this comment.
I guess this is ok for now, but if we are going to run different tests for different targets matrix may not make much sense here anymore. If we are always going to have 2, then we can just have base job and upgrade job. They will still run in parallel. We can leave it like this for now though, I guess, and leave it for a later reorg PR.
There was a problem hiding this comment.
I think we will run upgrade test for every version other than initial (v2)
* disable saving of VID shares (for now) * add to RUSTSEC ignore
addresses #2211
This PR removes the V1 version variants from the binaries, as they are no longer in use. The mainnet will launch with fees as the initial version, which is V2. This change speeds up binary compilation.
It also updates the integration CI to only run smoke test and not the upgrade test. We can remove this but I think the smoke test has more validation like the transactions submission that demo-native CI does not have