Skip to content

Commit

Permalink
make user-facing options partial
Browse files Browse the repository at this point in the history
  • Loading branch information
jcfranco committed Feb 7, 2025
1 parent 5265378 commit d699087
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class Dialog extends LitElement implements OpenCloseComponent, LoadableCo
* `"returnFocusOnDeactivate"` returns focus when not active, and
* `"extraContainers"` specifies additional focusable elements external to the trap (e.g., 3rd-party components appending elements to the document body).
*/
@property() focusTrapOptions: FocusTrapOptions;
@property() focusTrapOptions: Partial<FocusTrapOptions>;

/** The component header text. */
@property() heading: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/modal/modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export class Modal extends LitElement implements OpenCloseComponent, LoadableCom
* `"returnFocusOnDeactivate"` returns focus when not active, and
* `"extraContainers"` specifies additional focusable elements external to the trap (e.g., 3rd-party components appending elements to the document body).
*/
@property() focusTrapOptions: FocusTrapOptions;
@property() focusTrapOptions: Partial<FocusTrapOptions>;

/** Sets the component to always be fullscreen. Overrides `widthScale` and `--calcite-modal-width` / `--calcite-modal-height`. */
@property({ reflect: true }) fullscreen: boolean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export class Popover
* `"returnFocusOnDeactivate"` returns focus when not active, and
* `"extraContainers"` specifies additional focusable elements external to the trap (e.g., 3rd-party components appending elements to the document body).
*/
@property() focusTrapOptions: FocusTrapOptions;
@property() focusTrapOptions: Partial<FocusTrapOptions>;

/** The component header text. */
@property() heading: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/sheet/sheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export class Sheet extends LitElement implements OpenCloseComponent, LoadableCom
* `"returnFocusOnDeactivate"` returns focus when not active, and
* `"extraContainers"` specifies additional focusable elements external to the trap (e.g., 3rd-party components appending elements to the document body).
*/
@property() focusTrapOptions: FocusTrapOptions;
@property() focusTrapOptions: Partial<FocusTrapOptions>;

/**
* When `position` is `"block-start"` or `"block-end"`, specifies the height of the component.
Expand Down

0 comments on commit d699087

Please sign in to comment.