Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel: tokens to target header actions not working #11491

Open
2 of 6 tasks
allyshah opened this issue Feb 7, 2025 · 0 comments
Open
2 of 6 tasks

Panel: tokens to target header actions not working #11491

allyshah opened this issue Feb 7, 2025 · 0 comments
Assignees
Labels
2 - in development Issues that are actively being worked on. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design-tokens Issues requiring design tokens. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@allyshah
Copy link

allyshah commented Feb 7, 2025

Check existing issues

Actual Behavior

Tokens for header actions don't work. Our team (ArcGIS Dashboards) sees that the PR was merged and the new tokens are on the doc site but they don't work. Solution released on Feb 6,2025 did not resolve issue. Not working in next.116.

Puled from original note/ request from our team describing issue (1/10):

Panel header background & action colors
Changing a panel header background with the new --calcite-panel-header-background doesn't look great without also changing the action colors to match using the --calcite-action-*-color variables. However, setting these variables on the calcite-panel will affect all actions in the panel and there isn’t a way to target only the actions in the header. Selecting the actions slotted in the header isn’t sufficient as that won’t include the menu.

What I could do is set the actions to the header color on the panel, and then select the actions in the panel body and “reset” them.

calcite-panel {
--calcite-panel-header-background-color: #4874;
--calcite-panel-heading-text-color: #fff;
--calcite-action-background-color: #4874;
--calcite-action-background-color-hover: #023452;
--calcite-action-background-color-pressed: #023452;
--calcite-action-text-color: #fff;
--calcite-action-text-color-hover: #fff;
--calcite-action-text-color-pressed: #fff;
.panel-body {
--calcite-action-background-color: initial;
--calcite-action-background-color-hover: initial;
--calcite-action-background-color-pressed: initial;
--calcite-action-text-color: intial;
--calcite-action-text-color-hover: initial;
--calcite-action-text-color-pressed: initial;
}
}

Would this be the recommended workflow or would calcite consider adding variables to directly target the header actions?-----


(2/6) Proposed work around noted, but our team will wait for a true fix. Posting work around:
Ali Stump: I would recommend you use the panel body and “reset” solution for the time being. I have been trying to identify the error here and running into problems.

Our team will not release in 25.R1. and awaits the fix.

Similarity with this issue is noted in this existing, closed issue: #10519

Tagging @alisonailea @jcfranco

Expected Behavior

Functional header token

Reproduction Sample

coming soon

Reproduction Steps

  1. go to https://next-preview.sites.afd.arcgis.com/calcite-design-system/components/panel/
  2. check here by changing any of the --calcite-panel-header-action-* colors
  3. notice the issue: there is no change

Reproduction Version

3.0.0-next.132

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

Our team will not release in 25.R1. and awaits the fix.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Dashboards

@allyshah allyshah added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 7, 2025
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Feb 7, 2025
@allyshah allyshah changed the title Merged Header Token does not work Merged tokens to target header actions not working Feb 7, 2025
@allyshah allyshah changed the title Merged tokens to target header actions not working Panel: tokens to target header actions not working Feb 7, 2025
@brittneytewks brittneytewks added design-tokens Issues requiring design tokens. and removed needs triage Planning workflow - pending design/dev review. labels Feb 7, 2025
@brittneytewks brittneytewks added this to the 3.0.0 Patch - 2025-02-19 milestone Feb 7, 2025
@brittneytewks brittneytewks added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 7, 2025
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. labels Feb 7, 2025
@macandcheese macandcheese added the ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. label Feb 10, 2025
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - in development Issues that are actively being worked on. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design-tokens Issues requiring design tokens. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

5 participants