-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(panel): progressive enhancement to target calcite-actions in header #11495
base: dev
Are you sure you want to change the base?
Conversation
b6da073
to
268be2b
Compare
My 2c - supporting css parts has been discussed and we decided not to pursue for the near-term. It's a significant shift in customization story. The css token approach seems more on-story here - I do think it could perhaps be simplified to just target the internally rendered Actions and Action Menu - keeping your new props here and making the user story this:
This way, a user would just need to style Actions slotted in Example : https://github.com/Esri/calcite-design-system/blob/macandcheese/wip-panel-tokens-idea/packages/calcite-components/src/components/panel/panel.scss - this would mean we could remove the "pass through docs" for Action props on Panel to reduce confusion. |
I agree with @macandcheese here. |
…system into astump/panel-header
@alisonailea Can you fix the typo in the title and update the description with details of the final approach? Thanks! |
@@ -181,6 +167,27 @@ | |||
} | |||
} | |||
|
|||
.header { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can be more specific here, just assigning these to the internally-rendered Actions (
calcite-design-system/packages/calcite-components/src/components/panel/panel.scss
Line 170 in 0e1043f
#close, |
If so, we can update the css prop descriptions to specifically state the elements affected (like you have for the "part example").
Related Issue: #11491 #8675 #7180
Summary
Allow calcite-actions to be styled specific to the panel-header.
include
::slotted(calcite-action)
in selectors and set proper variable fallbacksCorrectly pass corner-radius through the component