Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dialog): add focusTrapDisabled property for non-modal dialogs #11362

Merged
merged 29 commits into from
Feb 5, 2025
Merged

feat(dialog): add focusTrapDisabled property for non-modal dialogs #11362

merged 29 commits into from
Feb 5, 2025

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jan 22, 2025

Related Issue: #10685

Summary

Add focusTrapDisabled attribute to for non-modal dialogs.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 22, 2025
@Elijbet Elijbet force-pushed the elijbet/10685-focusTrapDisabled-attribute-for-non-modal-dialogs branch from 3a1913a to 702b4c8 Compare January 22, 2025 22:04
@Elijbet Elijbet marked this pull request as ready for review January 24, 2025 23:36
@driskull
Copy link
Member

@Elijbet can we rename

feat(dialog): add focusTrapDisabled attribute to for non-modal dialogs

to feat(dialog): add focusTrapDisabled property for non-modal dialogs

@Elijbet Elijbet marked this pull request as draft January 28, 2025 21:36
driskull
driskull previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@driskull driskull self-requested a review January 31, 2025 23:45
@driskull driskull dismissed their stale review January 31, 2025 23:46

Reviewed too early

driskull
driskull approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice! 🎉

@Elijbet Elijbet marked this pull request as ready for review February 1, 2025 00:04
jcfranco
jcfranco approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @Elijbet! This should be good to merge once comments are addressed.

packages/calcite-components/src/utils/focusTrapComponent.spec.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/components/dialog/dialog.e2e.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/components/dialog/dialog.tsx Outdated Show resolved Hide resolved
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 5, 2025
@Elijbet Elijbet added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 5, 2025
@Elijbet Elijbet merged commit 31dae60 into dev Feb 5, 2025
10 checks passed
@Elijbet Elijbet deleted the elijbet/10685-focusTrapDisabled-attribute-for-non-modal-dialogs branch February 5, 2025 21:45
benelan pushed a commit that referenced this pull request Feb 8, 2025
@Elijbet @benelan
feat(dialog): add focusTrapDisabled property for non-modal dialogs (#…
44f486c 
…11362)

**Related Issue:** #10685

## Summary
Add `focusTrapDisabled` attribute to for non-`modal` `dialog`s.
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@driskull driskull driskull approved these changes

@geospatialem geospatialem geospatialem left review comments

Assignees

@Elijbet Elijbet

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

Successfully merging this pull request may close these issues.
4 participants
@Elijbet @driskull @jcfranco @geospatialem