feat(accordion): add new component tokens and deprecate old tokens #11390
+215
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonailea
requested review from
jcfranco,
eriklharper,
driskull and
macandcheese
alisonailea
changed the title
github-actions
bot
added
the
chore
eriklharper
approved these changes
Jan 27, 2025
packages/calcite-components/src/components/accordion-item/accordion-item.scss
Outdated
Show resolved
Hide resolved
macandcheese
approved these changes
Jan 27, 2025
driskull
reviewed
Jan 27, 2025
There was a problem hiding this comment.
@alisonailea can we also change this to a feat() instead of chore since new variables are being added?
Something like feat(accordion): add new component tokens and deprecate old tokens
packages/calcite-components/src/components/accordion-item/accordion-item.scss
Show resolved
Hide resolved
driskull
requested changes
Jan 27, 2025
jcfranco
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
…mp/11389-accordion
alisonailea
changed the title
github-actions
bot
added
the
enhancement
alisonailea
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10830
Summary
Deprecate
--calcite-accordion-item-background-colorDeprecate
--calcite-accordion-item-border-colorDeprecate
--calcite-accordion-item-icon-colorDeprecate
--calcite-accordion-item-text-colorDeprecate
--calcite-accordion-item-text-color-hoverDeprecate
--calcite-accordion-item-text-color-press--calcite-accordion-border-color: Specifies the component's border color.
--calcite-accordion-background-color: Specifies the component's background color.
--calcite-accordion-text-color: Specifies the component's text color.
--calcite-accordion-text-color-hover: Specifies the component's main text color on hover.
--calcite-accordion-text-color-press: Specifies the component's main text color when pressed.
--calcite-accordion-item-background-color: [Deprecated] Use --calcite-accordion-background-color. Specifies the component's background color.
--calcite-accordion-item-border-color: [Deprecated] Use --calcite-accordion-border-color. Specifies the component's border color.
--calcite-accordion-item-content-space: Specifies the component's padding.
--calcite-accordion-item-end-icon-color: Specifies the component's iconEnd color. Fallback to --calcite-accordion-item-icon-color or current color.
--calcite-accordion-item-expand-icon-color: Specifies the component's expand icon color.
--calcite-accordion-item-header-background-color: Specifies the component's heading background color.
--calcite-accordion-item-heading-text-color: Specifies the component's heading text color.
--calcite-accordion-item-icon-color: [Deprecated] Use --calcite-icon-color. Specifies the component's default icon color.
--calcite-accordion-item-start-icon-color: Specifies the component's iconStart color. Fallback to --calcite-accordion-item-icon-color or current color.
--calcite-accordion-item-text-color: [Deprecated] Use --calcite-accordion-text-color. Specifies the component's text color.
--calcite-accordion-item-text-color-hover: [Deprecated] Use --calcite-accordion-text-color-hover. Specifies the component's text color on hover.
--calcite-accordion-item-text-color-press: [Deprecated] Use --calcite-accordion-text-color-press. Specifies the component's text color on press.