Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): toggle focus-trap on DOM connect and disconnect #11429

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(dialog): toggle focus-trap on DOM connect and disconnect #11429

wants to merge 2 commits into from
+131 −40

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 1, 2025 •
edited
Loading

Related Issue: #10731

Summary

Fixes an issue where a focus-trap instance might be left active after the dialog is removed.

Relevant changes

  • Adds useFocusTrap controller
  • Extracts and exports function to create default focus-trap options

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 1, 2025
@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Feb 1, 2025
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 1, 2025
@jcfranco jcfranco marked this pull request as ready for review February 1, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfranco