Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carousel): Improve Carousel navigation display #11439

Merged
merged 5 commits into from
Feb 4, 2025
Merged

fix(carousel): Improve Carousel navigation display #11439

merged 5 commits into from
Feb 4, 2025

Conversation

macandcheese
Copy link
Contributor

@macandcheese macandcheese commented Feb 3, 2025 •
edited
Loading

Related Issue: #11426

Summary

Adjusts colors for the navigation controls in Carousel component.

Before After
Screenshot 2025-02-03 at 3 42 42 PM Screenshot 2025-02-03 at 3 42 35 PM

@macandcheese macandcheese added figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 3, 2025
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 3, 2025
@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Feb 3, 2025
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 4, 2025
@macandcheese macandcheese added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 4, 2025
SkyeSeitz
SkyeSeitz approved these changes Feb 4, 2025
View reviewed changes
Copy link

@SkyeSeitz SkyeSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macandcheese macandcheese merged commit e735d41 into dev Feb 4, 2025
15 checks passed
@macandcheese macandcheese deleted the macandcheese/11426-improve-carousel-display branch February 4, 2025 17:34
benelan pushed a commit that referenced this pull request Feb 8, 2025
@macandcheese @benelan
fix(carousel): Improve Carousel navigation display (#11439)
20a3ea8 
**Related Issue:** #11426

## Summary
Adjusts colors for the navigation controls in Carousel component.

| Before    | After |
| -------- | ------- |
| ![Screenshot 2025-02-03 at 3 42
42 PM](https://github.com/user-attachments/assets/50ae51df-76e7-44f9-83ae-917797bdbbb2)
| ![Screenshot 2025-02-03 at 3 42
35 PM](https://github.com/user-attachments/assets/f38046fe-4591-46dd-9881-eacbb829148b)
|
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@SkyeSeitz SkyeSeitz SkyeSeitz approved these changes

@driskull driskull Awaiting requested review from driskull

@alisonailea alisonailea Awaiting requested review from alisonailea

@ashetland ashetland Awaiting requested review from ashetland

Assignees

@macandcheese macandcheese

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@macandcheese @jcfranco @SkyeSeitz