Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text-area): add limitText prop to prevent input beyond max-length #11440

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat(text-area): add limitText prop to prevent input beyond max-length #11440

merged 2 commits into from
Feb 4, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 3, 2025 •
edited
Loading

Related Issue: #10175

Summary

Adds limitText prop to restrict input beyond the specified max-length, aligning with native behavior.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Feb 3, 2025
@jcfranco jcfranco changed the title feat(text-area): add limit-text prop to prevent input beyond max-length (following native behavior) feat(text-area): add limit-text prop to prevent input beyond max-length Feb 4, 2025
@jcfranco jcfranco changed the title feat(text-area): add limit-text prop to prevent input beyond max-length feat(text-area): add limitText prop to prevent input beyond max-length Feb 4, 2025
@jcfranco jcfranco requested a review from mpriour February 4, 2025 00:07
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 4, 2025
driskull
driskull approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/calcite-components/src/components/text-area/text-area.tsx Outdated Show resolved Hide resolved
mpriour
mpriour approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@mpriour mpriour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@jcfranco jcfranco merged commit 4835dee into dev Feb 4, 2025
13 checks passed
@jcfranco jcfranco deleted the jcfranco/10175-add-prop-to-enforce-text-area-max-length branch February 4, 2025 17:58
benelan pushed a commit that referenced this pull request Feb 8, 2025
@jcfranco @benelan
feat(text-area): add limitText prop to prevent input beyond max-len…
2cfc1c9 
…gth (#11440)

**Related Issue:** #10175 

## Summary

Adds `limitText` prop to restrict input beyond the specified
`max-length`, aligning with native behavior.
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper left review comments

@mpriour mpriour mpriour approved these changes

@driskull driskull driskull approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

@anveshmekala anveshmekala Awaiting requested review from anveshmekala

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

Successfully merging this pull request may close these issues.
4 participants
@jcfranco @mpriour @eriklharper @driskull