feat(rating): enhance component's interactivity states #11469
+26
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciado88/10015-rating-enhance-component-interactivity-states
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
jcfranco
approved these changes
Feb 14, 2025
| "--calcite-rating-color-press": { | ||
| shadowSelector: `.${CSS.star}`, | ||
| targetProp: "color", | ||
| state: { press: { attribute: "class", value: CSS.star } }, |
There was a problem hiding this comment.
The object argument to state.press is deprecated. Use a selector instead (see example).
| @@ -5,7 +5,8 @@ | |||
| * | |||
| * @prop --calcite-rating-spacing-unit: [Deprecated] Use `--calcite-rating-spacing`. Specifies the amount of left and right margin spacing between each item. | |||
| * @prop --calcite-rating-spacing: Specifies the amount of left and right margin spacing between each item. | |||
| * @prop --calcite-rating-color-hover: Specifies the component's item color when hovered or selected. | |||
| * @prop --calcite-rating-color-hover: Specifies the component's item color when hovered. | |||
| * @prop --calcite-rating-color-press: Specifies the component's item color when active. | |||
There was a problem hiding this comment.
+@geospatialem @DitwanP @matgalla for CSS prop doc review.
| @@ -70,7 +77,7 @@ | |||
|
|
|||
| .hovered, | |||
There was a problem hiding this comment.
Is .hovered still applicable here? It seems like it might be overridden above.
aPreciado88
added
pr ready for visual snapshots
|
@ashetland @SkyeSeitz Can you please take a look? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10015
Summary
fillon:hover.--calcite-color-brand-hoveron:hover.--calcite-color-brand-presson:active.--calcite-rating-color-presscss token.