Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop deprecated loadable component utilities #11479

Merged
merged 4 commits into from
Feb 13, 2025
Merged

refactor: drop deprecated loadable component utilities #11479

merged 4 commits into from
Feb 13, 2025

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Feb 7, 2025

Related Issue: #11333

Summary

Remove the deprecated loadable util and use componentOnReady directly.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Feb 7, 2025
@Elijbet Elijbet marked this pull request as ready for review February 10, 2025 19:20
jcfranco
jcfranco approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for helping with this @Elijbet!

Once the missed replacement is addressed, this should be good to merge. 🚀

packages/calcite-components/src/components/combobox/combobox.tsx Show resolved Hide resolved
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 12, 2025
@Elijbet Elijbet merged commit d8489e7 into dev Feb 13, 2025
14 checks passed
@Elijbet Elijbet deleted the elijbet/11333-drop-deprecated-LoadableComponent-utilities branch February 13, 2025 00:07
@github-actions github-actions bot added this to the 2025-02-25 - Feb Milestone milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@Elijbet Elijbet

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elijbet @jcfranco