Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tab-title): enhance component's interactivity states #11493

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat(tab-title): enhance component's interactivity states #11493

merged 1 commit into from
Feb 10, 2025

Conversation

aPreciado88
Copy link
Contributor

@aPreciado88 aPreciado88 commented Feb 7, 2025 •
edited
Loading

Related Issue: #10003

Summary

  • Increase bottom-border to 4px on focus when selected=true.
  • Change text-color-3 to text-color-1 on hover and active when bordered=false and selected=false.
  • When bordered=true:
    • Remove hover and active states when selected=true.
    • Change text-color-3 to text-color-1 on hover and active when selected=false.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Feb 7, 2025
@aPreciado88 aPreciado88 added this to the 2025-02-25 - Feb Milestone milestone Feb 7, 2025
@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 7, 2025
jcfranco
jcfranco approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's hold off on merging this until 3.0 is released.

@aPreciado88
Copy link
Contributor Author

@ashetland @SkyeSeitz Can you please take a look at the new screenshots?

ashetland
ashetland approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@aPreciado88 aPreciado88 merged commit f9d27fa into dev Feb 10, 2025
19 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/10003-tab-title-enhance-component-interactivity-states branch February 10, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@ashetland ashetland ashetland approved these changes

@SkyeSeitz SkyeSeitz Awaiting requested review from SkyeSeitz

Assignees

@aPreciado88 aPreciado88

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aPreciado88 @jcfranco @ashetland @benelan