-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit fburn for esp8266 #1115
Permit fburn for esp8266 #1115
Conversation
- add a macro to allow selecting the root device at the kernel compile time - remove blkdiscard as it does not compile
Can you stick some info in on the blkdiscard build fail and lets deal with that separately not quietly lose it in an unrelated pull. Otherwise looks good to me at first glance. |
Of course, would you mind if I squash/rebase to keep only one commit? |
I needed to update the default boot device selection because it was broken before, sorry for that. I also removed the blkdiscard part of the PR. In the meantime I also found that blkdiscard.c compiles fine, but as it is absent from the Makefile.common file in Application/util, we can't upload it into our flash image. So I wonder if the best path is to remove it from update-flash.sh or if we can use Makefile.generic in Makefile.esp8266 for the applications, or if we can add it to Makefile.common. The later cases can have impact for other platforms but I'm not aware of the consequences. |
thanks |
@palainp Hi.
I'm still getting a Kernel Panic. Am I missing a step? should I do "fburn" instead?
|
Dear @ermiah , I don't use the SD card since the PR which allows me to put the file system on the flash part of my device. So yes, what I do is use
Now, back to your issue, it seems that the kernel is unable to run |
Dear @ermiah, @EtchedPixels,
This PR want to continue the work #1090 and now make fburn should works fine (it needs an additional call to ld to generate the segment headers, maybe there is a clever way to add them).
As I don't use anymore the SD card reader for the root filesystem, and as now fburn works fine, I've booted correctly without the panic in #1091. @ermiah would you mind to try to boot on the flash drive? (it requires to recompile the kernel
with a new optionafter an updating config.h)Best.