[IR-3773]: fix calculateAndApplyOffset regression #10939
Conversation
dtlehrer
requested review from
aditya-mitra,
SYBIOTE,
CITIZENDOT and
HexaField
as code owners
|
Closing as this was solved by #10938 |
dtlehrer
changed the title
dtlehrer
changed the title
|
reopening & changing description - this resolves IR-3773, fixing overflow bug as seen in the recordings below before: after (with these changes): |
There was a problem hiding this comment.
reopening & changing description - this resolves IR-3773, fixing overflow bug as seen in the recordings below
before: https://github.com/user-attachments/assets/6817c558-a3c3-4410-b337-11a76f2a5499
after (with these changes): https://github.com/user-attachments/assets/33ea5d4a-5f6a-4410-8aa3-d6be2109586f
Hi @dtlehrer, you are right, this totally needs fixing.
Can you tell me the reproduction steps for it? (Unable to follow it from the video)
packages/ui/src/components/editor/panels/Properties/container/index.tsx
Outdated
Show resolved
Hide resolved
you should be able to reproduce by zooming in and/or reducing the size of your browser window.. and then tapping the 'add component' button to open that menu. on my machine, I start to see the top of the menu overflow the screen when I zoom the browser in to >= 110% |
Summary
IR-3773: to fix Add Entity & Add Component menu overflow at different browser sizes, dynamically repositioning if menu overflows the top
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps