Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary sp field from OptimizedStack. #276

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Removing unnecessary sp field from OptimizedStack. #276

merged 7 commits into from
Jun 13, 2024

Conversation

cokicm
Copy link

@cokicm cokicm commented Jun 6, 2024 •
edited
Loading

Description

Removing unnecessary sp field from OptimizedStack

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@cokicm cokicm added the enhancement New feature or request label Jun 6, 2024
@cokicm cokicm self-assigned this Jun 6, 2024
oliverbundalo
oliverbundalo approved these changes Jun 7, 2024
View reviewed changes
Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 10, 2024
View reviewed changes
Copy link

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comments from Goran and Oliver, LGTM!

Stefan-Ethernal
Stefan-Ethernal approved these changes Jun 12, 2024
View reviewed changes
Copy link

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from minor nitpicks, LGTM!

@Stefan-Ethernal Stefan-Ethernal merged commit 1adcbeb into develop Jun 13, 2024
10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the feature/remove-sp-from-optimized-stack branch June 13, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@oliverbundalo oliverbundalo oliverbundalo approved these changes

Assignees

@cokicm cokicm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cokicm @Stefan-Ethernal @goran-ethernal @oliverbundalo