check and download split

Etuldan · Jan 31, 2023 · 3f4b01b · 3f4b01b
1 parent ca985a0
commit 3f4b01b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/GitHubdate/GitHubdate.cs b/GitHubdate/GitHubdate.cs
@@ -24,7 +24,7 @@ public GitHubdate(string Username, string Project, string InstallArguments = "",
             _serviceGitHubInfo = new GitHubService(Username, Project);
         }
 
-        private async Task DownloadAndInstall()
+        public async Task DownloadAndInstall()
         {
             var fullPath = Path.Combine(Path.GetTempPath(), _gitHubInformations.FileName);
 
@@ -45,7 +45,8 @@ private async Task DownloadAndInstall()
                     UseShellExecute = false,
                     FileName = fullPath,
                     WindowStyle = ProcessWindowStyle.Hidden,
-                    Arguments = _installArguments
+                    Arguments = _installArguments,
+                    Verb = "runas"
                 };
                 try
                 {
@@ -60,36 +61,35 @@ private async Task DownloadAndInstall()
             }
         }
 
-        public async Task Check()
+        public async Task<bool> Check()
         {
             _gitHubInformations = await _serviceGitHubInfo.FetchInfo();
             if( _gitHubInformations == null || _gitHubInformations.DownloadUrl == null || _gitHubInformations.FileName == null || _gitHubInformations.Version == null)
             {
-                return;
+                return false;
             }
             if (_gitHubInformations.Version.CompareTo(_serviceLocalInfo.Version) > 0)
             {
                 if (!_automaticUpdate)
                 {
-                    MessageBoxButtons buttons = MessageBoxButtons.YesNo;
-                    DialogResult result;
-
-                    result = MessageBox.Show(
+                    var buttons = MessageBoxButtons.YesNo;
+                    var result = MessageBox.Show(
                         $"Current version: {_serviceLocalInfo.Version}\n" +
                         $"Available version: {_gitHubInformations.Version}\n\n" +
                         _gitHubInformations.Description, 
                         $"Update available { _gitHubInformations.Name}", 
                         buttons);
                     if (result == DialogResult.Yes)
                     {
-                        await DownloadAndInstall();
+                        return true;
                     }
                 }
                 else
                 {
-                    await DownloadAndInstall();
+                    return true;
                 }
             }
+            return false;
         }
     }
 }
diff --git a/TestGitHubdate/Program.cs b/TestGitHubdate/Program.cs
@@ -4,7 +4,11 @@ internal class Program
 {
     static async Task Main(string[] args)
     {
-        var downloader = new GitHubdate.GitHubdate("Etuldan", "MidiControl", "/SILENT /NOCANCEL /NORESTART /FORCECLOSEAPPLICATIONS /SUPPRESSMSGBOXES", false);
-        await downloader.Check();
+        var downloader = new GitHubdate.GitHubdate("Etuldan", "GitHubdate");
+        var result = await downloader.Check();
+        if (result == true)
+        {
+            await downloader.DownloadAndInstall();
+        }
     }
 }