Handle empty 204 Requests returned by CCP's PUT and DELETE methods #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESI returns HTTP 204 responses for PUT and DELETE operations.
There's a deficiency in the base oauth2 library that sends empty response bodies to
json_decode()
, which then throws anUnexpectedValueException
even though the request has succeeded and returned a 2xx ( 204 in this case ) response status code.This workaround solves the issue: