WIP: Migration to ORM with ODB #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d code to avoid O(N), N - is TotalSkillsCount * 5 complexity.
…to giveallskills_fix
|
@SantjagoCorkez Great work so far! I really like the direction this is going in 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a sample implementation of the problematic code I've pointed to in #178
The ODB manual is here: https://www.codesynthesis.com/products/odb/doc/manual.xhtml
My measurements for console command
test(which callsMarketMgr::SetBasePrice()):It's still a work-in-progress since there's still a lot to implement (database schema initialization, migrations and so on).
I didn't check if the cmake install properly installs the eve-db.so (which must be a shared library or the code will segfault) but the build and run from the project directory works.