Dev/refactor #23
685 new problems found by Qodana for .NET
Qodana for .NET
685 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Invalid property value |
🔴 Failure | 122 |
Unresolved custom property |
🔴 Failure | 8 |
Invalid pseudo-selector |
🔴 Failure | 5 |
Annotator |
🔴 Failure | 1 |
Redundant measure unit |
🔶 Warning | 36 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 34 |
Redundant character escape |
🔶 Warning | 27 |
Unnecessary non-capturing group |
🔶 Warning | 15 |
Missing generic font family name |
🔶 Warning | 14 |
Overwritten property |
🔶 Warning | 8 |
Unknown property |
🔶 Warning | 8 |
Possible performance issues caused by unlimited string length |
🔶 Warning | 5 |
Expression is always 'true' or 'false' according to nullable reference types' annotations |
🔶 Warning | 3 |
Begin or end anchor in unexpected position |
🔶 Warning | 3 |
Missing required 'lang' attribute |
🔶 Warning | 2 |
Redundant using directive |
🔶 Warning | 2 |
Annotator |
🔶 Warning | 1 |
Async function without await expression |
🔶 Warning | 1 |
Unused selector |
🔶 Warning | 1 |
Unknown attribute |
🔶 Warning | 1 |
Redundant type arguments of method |
🔶 Warning | 1 |
Duplicate character in character class |
🔶 Warning | 1 |
Method return value is never used (private accessibility) |
🔶 Warning | 1 |
Variable can be declared as non-nullable |
🔶 Warning | 1 |
Use preferred 'var' style (when type is simple) |
◽️ Notice | 133 |
Use preferred 'var' style (for built-in types) |
◽️ Notice | 45 |
Use preferred 'var' style (elsewhere) |
◽️ Notice | 37 |
Property can be made init-only (non-private accessibility) |
◽️ Notice | 34 |
Replace with primary constructor parameter |
◽️ Notice | 21 |
Non-integer length in pixels |
◽️ Notice | 20 |
RoslynAnalyzers Template should be a static expression |
◽️ Notice | 14 |
Invert 'if' statement to reduce nesting |
◽️ Notice | 11 |
Type member is never used (non-private accessibility) |
◽️ Notice | 11 |
Regular expression can be simplified |
◽️ Notice | 8 |
Redundant verbatim string prefix |
◽️ Notice | 6 |
Route parameter constraint can be added due to type of method argument |
◽️ Notice | 6 |
Convert constructor into primary constructor |
◽️ Notice | 5 |
RoslynAnalyzers Unused route parameter |
◽️ Notice | 3 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 3 |
Not all route parameters are passed to method |
◽️ Notice | 3 |
Route parameter can be passed to method |
◽️ Notice | 3 |
Use collection expression syntax |
◽️ Notice | 3 |
'if' statement can be rewritten as '??=' assignment |
◽️ Notice | 2 |
Loop can be converted into LINQ-expression |
◽️ Notice | 2 |
Redundant 'else' keyword |
◽️ Notice | 2 |
Auto-property can be made get-only (non-private accessibility) |
◽️ Notice | 1 |
RoslynAnalyzers Instantiate argument exceptions correctly |
◽️ Notice | 1 |
RoslynAnalyzers Named placeholders should not be numeric values |
◽️ Notice | 1 |
Class with virtual (overridable) members never inherited (non-private accessibility) |
◽️ Notice | 1 |
Convert local variable or field into constant (private accessibility) |
◽️ Notice | 1 |
Inline temporary variable |
◽️ Notice | 1 |
Merge conditional ?: expression into conditional access |
◽️ Notice | 1 |
Merge null/pattern/value checks into 'or'/'and' patterns |
◽️ Notice | 1 |
Local variable has too wide declaration scope |
◽️ Notice | 1 |
Type member is never accessed via base type (non-private accessibility) |
◽️ Notice | 1 |
Unused parameter (non-private accessibility) |
◽️ Notice | 1 |
Type is never used (non-private accessibility) |
◽️ Notice | 1 |
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check notice on line 24 in Frontend/Controllers/HomeController.cs
github-actions / Qodana for .NET
RoslynAnalyzers Unused route parameter
Unused route parameter 'id'
Check notice on line 176 in Frontend/Controllers/PatientsController.cs
github-actions / Qodana for .NET
RoslynAnalyzers Unused route parameter
Unused route parameter 'id'
Check notice on line 159 in Frontend/Controllers/NotesController.cs
github-actions / Qodana for .NET
RoslynAnalyzers Unused route parameter
Unused route parameter 'id'
Check warning on line 1429 in Frontend/wwwroot/lib/jquery-validation/dist/additional-methods.js
github-actions / Qodana for .NET
Annotator
Redundant group nesting
Check failure on line 1346 in Frontend/wwwroot/lib/jquery/dist/jquery.js
github-actions / Qodana for .NET
Annotator
Unexpected token
Check notice on line 7 in Frontend/Models/DiabetesRiskPrediction.cs
github-actions / Qodana for .NET
Auto-property can be made get-only (non-private accessibility)
Auto-property can be made get-only
Check notice on line 23 in ApiGateway/Program.cs
github-actions / Qodana for .NET
RoslynAnalyzers Instantiate argument exceptions correctly
Method $ passes 'secretKey' as the paramName argument to a ArgumentNullException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.
Check notice on line 35 in Frontend/Controllers/HomeController.cs
github-actions / Qodana for .NET
RoslynAnalyzers Named placeholders should not be numeric values
Named placeholders in the logging message template should not be comprised of only numeric characters
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
Check notice on line 69 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogDebug(ILogger, string?, params object?\[\])'
Check notice on line 15 in Frontend/Services/ErrorHandling.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogError(ILogger, string?, params object?\[\])'
Check notice on line 106 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
Check notice on line 102 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
Check notice on line 103 in BackendNote/Services/NotesService.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogError(ILogger, string?, params object?\[\])'
Check notice on line 42 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
Check notice on line 116 in BackendNote/Services/NotesService.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogError(ILogger, string?, params object?\[\])'
Check notice on line 111 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogError(ILogger, string?, params object?\[\])'
Check notice on line 48 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
Check notice on line 75 in Auth/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?\[\])'
Check notice on line 97 in BackendNote/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogDebug(ILogger, string?, params object?\[\])'
Check notice on line 101 in BackendNote/Data/DataSeeder.cs
github-actions / Qodana for .NET
RoslynAnalyzers Template should be a static expression
The logging message template should not vary between calls to 'LoggerExtensions.LogDebug(ILogger, string?, params object?\[\])'
Check warning on line 62 in Frontend/Services/PatientService.cs
github-actions / Qodana for .NET
Async function without await expression
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Check notice on line 3 in BackendDiabetesRiskPrediction/Models/NoteRiskInfo.cs
github-actions / Qodana for .NET
Class is never instantiated (non-private accessibility)
Class 'NoteRiskInfo' is never instantiated
Check notice on line 3 in BackendDiabetesRiskPrediction/Models/PatientRiskInfo.cs
github-actions / Qodana for .NET
Class is never instantiated (non-private accessibility)
Class 'PatientRiskInfo' is never instantiated