Merge pull request #38 from EventStore/timothycoleman/plugablecomponents

Unify Telemetry Collection and DI usage into one interface: IPlugableComponent

src/EventStore.Plugins/Authentication/IAuthenticationProvider.cs

@@ -3,7 +3,7 @@
 using Microsoft.AspNetCore.Routing;
 
 namespace EventStore.Plugins.Authentication {
-	public interface IAuthenticationProvider {
+	public interface IAuthenticationProvider : IPlugableComponent {
 		/// <summary>
 		///     Initialize the AuthenticationProvider. Event Store will wait until this task completes before becoming ready.
 		/// </summary>

src/EventStore.Plugins/Authentication/IHttpAuthenticationProvider.cs

@@ -2,7 +2,7 @@
 
 namespace EventStore.Plugins.Authentication;
 
-public interface IHttpAuthenticationProvider : IConfigureServices {
+public interface IHttpAuthenticationProvider {
 	/// <summary>
 	///     Return a unique name used to externally identify the authentication provider.
 	/// </summary>

src/EventStore.Plugins/Authorization/IAuthorizationProvider.cs

@@ -3,7 +3,7 @@
 using System.Threading.Tasks;
 
 namespace EventStore.Plugins.Authorization {
-	public interface IAuthorizationProvider : IConfigureServices {
+	public interface IAuthorizationProvider : IPlugableComponent {
 		/// <summary>
 		///     Check whether the provided <see cref="ClaimsPrincipal" /> has the rights to perform the <see cref="Operation" />
 		/// </summary>

src/EventStore.Plugins/IPlugableComponent.cs

@@ -0,0 +1,15 @@
+using System.Text.Json.Nodes;
+using System;
+using Microsoft.AspNetCore.Builder;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace EventStore.Plugins;
+
+// Component that can be plugged in to the main server.
+// Plugins are libraries that result in IPlugableComponents being produced and plugged in.
+public interface IPlugableComponent {
+	IApplicationBuilder Configure(IApplicationBuilder builder) => builder;
+	IServiceCollection ConfigureServices(IServiceCollection services, IConfiguration configuration) => services;
+	void CollectTelemetry(Action<string, JsonNode> reply) { }
+}

src/EventStore.Plugins/MD5/IMD5Plugin.cs

@@ -1,16 +1,10 @@
-using System;
-using System.Text.Json.Nodes;
-
-namespace EventStore.Plugins.MD5;
+namespace EventStore.Plugins.MD5;
 
 public interface IMD5Plugin {
 	string Name { get; }
 	string Version { get; }
-
 	string CommandLineName { get; }
 
-	void CollectTelemetry(Action<string, JsonNode> reply);
-
 	/// <summary>
 	///     Creates an MD5 provider factory for the MD5 plugin
 	/// </summary>

src/EventStore.Plugins/MD5/IMD5Provider.cs

@@ -2,7 +2,7 @@
 
 namespace EventStore.Plugins.MD5;
 
-public interface IMD5Provider : IConfigureServices {
+public interface IMD5Provider : IPlugableComponent {
 	/// <summary>
 	///     Creates an instance of the MD5 hash algorithm implementation
 	/// </summary>

src/EventStore.Plugins/Subsystems/ISubsystem.cs

@@ -1,15 +1,9 @@
-using System;
-using System.Text.Json.Nodes;
-using System.Threading.Tasks;
-using Microsoft.AspNetCore.Builder;
-using Microsoft.Extensions.Configuration;
-using Microsoft.Extensions.DependencyInjection;
+using System.Threading.Tasks;
 
 namespace EventStore.Plugins.Subsystems;
 
-public interface ISubsystem : IConfigureServices {
+public interface ISubsystem : IPlugableComponent {
 	string Name { get; }
-	void CollectTelemetry(Action<string, JsonNode> reply);
 	Task Start();
 	Task Stop();
 }