-
Notifications
You must be signed in to change notification settings - Fork 175
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(connect): Rust ray exec (#3666)
## Description you can now specify the runner you want to use via native spark config ```py from daft.daft import connect_start from pyspark.sql import SparkSession server = connect_start() url = f"sc://localhost:{server.port()}" daft_spark = SparkSession.builder.appName("DaftConnectExample").remote(url).getOrCreate() daft_spark.conf.set("daft.runner", "ray") # or use native # daft_spark.conf.set("daft.runner", "native") df1 = daft_spark.read.parquet("~/datasets/tpcds/sf10/customer.parquet") df1.limit(10).show() ``` ## Note for reviewers so i had to do a bit of refactoring to get this to work, mostly in how the show string works. The actual ray implementation is isolated within the new `daft-ray-execution` lib, and it's just a wrapper around our existing python code. The idea with putting it in it's own lib is that it creates a better abstraction and if we want to later port more of that code into rust, it'll be a lot easier. also a few small drivebys that were bugging me while working on this - change `warn!`'s to `debug!`'s as it was cluttering the output on every command. - refactor `PlanIds` to actually reflects what it does, a `ResponseBuilder`. - the error output for unsupported relations was nasty, so i simplified it [here](https://github.com/Eventual-Inc/Daft/pull/3666/files#diff-0f6aee05ac5693372752b1eab7454e80142119479e41093d0b975bb777d83ffdR169) and [here](https://github.com/Eventual-Inc/Daft/pull/3666/files#diff-0f6aee05ac5693372752b1eab7454e80142119479e41093d0b975bb777d83ffdR169)
- Loading branch information
1 parent
c932ec9
commit 0e03303
Showing
25 changed files
with
769 additions
and
423 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.