Skip to content

Commit

Permalink
[BUG] Terminate nodes instead of stopping them (#3427)
Browse files Browse the repository at this point in the history
# Overview
Nodes were being stopped and saved for future re-use purposes. This PR
turns off caching by settings `cache_stopped_nodes` to `false`. This
tells ray to shut down the nodes when `ray down ...` is invoked.
  • Loading branch information
Raunak Bhagat authored Nov 26, 2024
1 parent 396a0af commit 8bdd9ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/assets/benchmarking_ray_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ cluster_name: '{{RAY_CLUSTER_NAME}}'
provider:
type: aws
region: us-west-2
cache_stopped_nodes: true
cache_stopped_nodes: false
security_group:
GroupName: ray-autoscaler-c1

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
uv pip install ray[default] boto3
- name: Dynamically update ray config file
run: |
id="ray-ci-run-${{ github.run_id }}_${{ github.run_attempt }}"
id="github-ci-${{ github.run_id }}_${{ github.run_attempt }}"
sed -i "s|{{RAY_CLUSTER_NAME}}|$id|g" .github/assets/benchmarking_ray_config.yaml
sed -i 's|{{PYTHON_VERSION}}|${{ inputs.python_version }}|g' .github/assets/benchmarking_ray_config.yaml
if [[ '${{ inputs.daft_version }}' ]]; then
Expand Down

0 comments on commit 8bdd9ec

Please sign in to comment.