ci: Remove daft tracing (#3692)

# Overview
Daft tracing was enabled by default. However, this can negatively affect
performance, so this PR opts to make daft-tracing disabled by default.

However, end-users can still choose to turn on daft-tracing by default
(should they so wish) by adding the `DAFT_ENABLE_RAY_TRACING=1`
environment variable.

.github/ci-scripts/job_runner.py

@@ -53,16 +53,13 @@ def submit_job(
     entrypoint_script: str,
     entrypoint_args: str,
     env_vars: str,
-    enable_ray_tracing: bool,
 ):
     if "GHA_OUTPUT_DIR" not in os.environ:
         raise RuntimeError("Output directory environment variable not found; don't know where to store outputs")
     output_dir = Path(os.environ["GHA_OUTPUT_DIR"])
     output_dir.mkdir(exist_ok=True, parents=True)
 
     env_vars_dict = parse_env_var_str(env_vars)
-    if enable_ray_tracing:
-        env_vars_dict["DAFT_ENABLE_RAY_TRACING"] = "1"
 
     client = JobSubmissionClient(address="http://localhost:8265")
 
@@ -116,7 +113,6 @@ def submit_job(
     parser.add_argument("--entrypoint-script", type=str, required=True)
     parser.add_argument("--entrypoint-args", type=str, required=True)
     parser.add_argument("--env-vars", type=str, required=True)
-    parser.add_argument("--enable-ray-tracing", action="store_true")
 
     args = parser.parse_args()
 
@@ -132,5 +128,4 @@ def submit_job(
         entrypoint_script=args.entrypoint_script,
         entrypoint_args=args.entrypoint_args,
         env_vars=args.env_vars,
-        enable_ray_tracing=args.enable_ray_tracing,
     )

.github/workflows/run-cluster.yaml

@@ -132,13 +132,12 @@ jobs:
           --entrypoint-script='${{ inputs.entrypoint_script }}' \
           --entrypoint-args='${{ inputs.entrypoint_args }}' \
           --env-vars='${{ inputs.env_vars }}' \
-          --enable-ray-tracing
     - name: Download log files from ray cluster
       if: always()
       run: |
         source .venv/bin/activate
-        ray rsync-down .github/assets/ray.yaml /tmp/ray/session_*/logs ray-daft-logs
-        find ray-daft-logs -depth -name '*:*' -exec bash -c '
+        ray rsync-down .github/assets/ray.yaml /tmp/ray/session_*/logs ray-logs
+        find ray-logs -depth -name '*:*' -exec bash -c '
         for filepath; do
           dir=$(dirname "$filepath")
           base=$(basename "$filepath")
@@ -173,5 +172,5 @@ jobs:
       if: always()
       uses: actions/upload-artifact@v4
       with:
-        name: ray-daft-logs
-        path: ray-daft-logs
+        name: ray-logs
+        path: ray-logs