Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: sql "extract" temporal function #3188

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

universalmind303
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Nov 6, 2024
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #3188 will not alter performance

Comparing universalmind303:sql-extract (bdf69e9) with main (d8cdf36)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this to docs as well!

@jaychia jaychia added the documentation Improvements or additions to documentation label Nov 6, 2024
@universalmind303
Copy link
Contributor Author

Let's add this to docs as well!

so this is a bit different than our catalog functions as it has special syntax. extract(<datetimefield> FROM <column>), and we don't have any mechanism for documenting these kind of exprs yet. (other ones being CAST)

@universalmind303 universalmind303 merged commit 61b6842 into Eventual-Inc:main Nov 6, 2024
42 checks passed
@universalmind303 universalmind303 deleted the sql-extract branch January 23, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants