[FEAT] daft-connect range use python generator #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgazelka
changed the title
andrewgazelka
changed the title
CodSpeed Performance ReportMerging #3308 will improve performances by 59.54%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
==========================================
+ Coverage 77.35% 77.39% +0.03%
==========================================
Files 678 677 -1
Lines 83119 83114 -5
==========================================
+ Hits 64296 64323 +27
+ Misses 18823 18791 -32
|
samster25
reviewed
Nov 18, 2024
daft/io/_range.py
Outdated
|
|
||
| def _range_generators(start: int, end: int, step: int) -> Iterator[Callable[[], Iterator[Table]]]: | ||
| def generator_for_value(value: int) -> Callable[[], Iterator[Table]]: | ||
| def generator() -> Iterator[Table]: |
There was a problem hiding this comment.
this is generating 1 row per table which will be extremely slow. Instead you should be calculating what range should go in each partition and then call something like Series.arange to generate the series in rust. Each partition can just be 1 table.
There was a problem hiding this comment.
what you are thinking interop will be like in this case. Are you thinking
- Series.arange is in rust →
- table gets sent to python (Iterator of Tables) →
- get python RangeScanOperator →
- then get rust binding of RangeScanOperator (
let scan_operator_handle = ScanOperatorHandle::from_python_scan_operator(range, py)?;)
There was a problem hiding this comment.
@samster25 I added partitions in
also added #3334 so we can switch over to pure arange approach
There was a problem hiding this comment.
resolving this as no response
colin-ho
reviewed
Nov 19, 2024
andrewgazelka
force-pushed
the
andrew/improve-range
branch
2 times, most recently
from
3244faf to
fb08980
Compare
colin-ho
approved these changes
Nov 20, 2024
andrewgazelka
force-pushed
the
andrew/improve-range
branch
from
fb08980 to
a67b1bf
Compare
Closed
andrewgazelka
force-pushed
the
andrew/improve-range
branch
from
a67b1bf to
3901ec2
Compare
andrewgazelka
force-pushed
the
andrew/improve-range
branch
from
3901ec2 to
4f1210c
Compare
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.