Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: expr simplifier #3393

Merged
merged 15 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/daft-logical-plan/src/optimization/optimizer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ impl Optimizer {
pub fn new(config: OptimizerConfig) -> Self {
let mut rule_batches = Vec::new();

// we want to simplify expressions first to make the rest of the rules easier
// dbg
// rule_batches.push(RuleBatch::new(
// vec![Box::new(SimplifyExpressionsRule::new())],
// RuleExecutionStrategy::FixedPoint(Some(3)),
// ));

// --- Split ActorPoolProjection nodes from Project nodes ---
// This is feature-flagged behind DAFT_ENABLE_ACTOR_POOL_PROJECTIONS=1
if config.enable_actor_pool_projections {
Expand Down
3 changes: 3 additions & 0 deletions src/daft-logical-plan/src/optimization/rules/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ mod push_down_filter;
mod push_down_limit;
mod push_down_projection;
mod rule;
mod simplify_expressions;
mod split_actor_pool_projects;

pub use drop_repartition::DropRepartition;
Expand All @@ -14,4 +15,6 @@ pub use push_down_filter::PushDownFilter;
pub use push_down_limit::PushDownLimit;
pub use push_down_projection::PushDownProjection;
pub use rule::OptimizerRule;
#[allow(unused_imports)]
pub use simplify_expressions::SimplifyExpressionsRule;
pub use split_actor_pool_projects::SplitActorPoolProjects;
Loading