Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Replace semicolons in filenames with underscore #3430

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

raunakab
Copy link
Contributor

Overview

For all filenames that contain a semicolon, replace each instance of the semicolon with an underscore.

- for all filenames that contain a semicolon, replace each instance of the semicolon with an underscore
@github-actions github-actions bot added the bug Something isn't working label Nov 26, 2024
@raunakab raunakab marked this pull request as ready for review November 26, 2024 01:54
@raunakab raunakab requested a review from jaychia November 26, 2024 01:54
@raunakab raunakab enabled auto-merge (squash) November 26, 2024 01:54
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #3430 will degrade performances by 28.35%

Comparing bug/remove-semicolons (68aa055) with main (8bdd9ec)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bug/remove-semicolons Change
test_iter_rows_first_row[100 Small Files] 372.2 ms 330 ms +12.79%
test_show[100 Small Files] 16 ms 22.4 ms -28.35%

@raunakab raunakab merged commit c012577 into main Nov 26, 2024
43 of 44 checks passed
@raunakab raunakab deleted the bug/remove-semicolons branch November 26, 2024 02:08
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.52%. Comparing base (8bdd9ec) to head (68aa055).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
- Coverage   77.34%   76.52%   -0.83%     
==========================================
  Files         684      684              
  Lines       83637    85187    +1550     
==========================================
+ Hits        64693    65189     +496     
- Misses      18944    19998    +1054     

see 29 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants