Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] shuffle testing #3492

Merged
merged 8 commits into from
Dec 5, 2024
Merged

[FEAT] shuffle testing #3492

merged 8 commits into from
Dec 5, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Dec 4, 2024

Overview

Add @colin-ho's shuffle testing PR to this repo; also add the ability to invoke it in CI runs.

@raunakab raunakab requested review from jaychia and removed request for jaychia December 4, 2024 22:51
@github-actions github-actions bot added the enhancement New feature or request label Dec 4, 2024
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #3492 will improve performances by 76.96%

Comparing feat/shuffle-testing (3b1dc95) with main (78c738f)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/shuffle-testing Change
test_iter_rows_first_row[100 Small Files] 309.8 ms 175.1 ms +76.96%

#3329 shows that we do not
currently support reading boolean values from parquet files when they
are RLE-encoded.

This PR adds support for this.
@raunakab raunakab force-pushed the feat/shuffle-testing branch from ee87872 to b618430 Compare December 4, 2024 23:04
@raunakab raunakab requested a review from jaychia December 4, 2024 23:05
@raunakab raunakab marked this pull request as ready for review December 4, 2024 23:05
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.37%. Comparing base (d1d0fab) to head (3b1dc95).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
- Coverage   77.34%   76.37%   -0.98%     
==========================================
  Files         696      702       +6     
  Lines       84849    87049    +2200     
==========================================
+ Hits        65630    66487     +857     
- Misses      19219    20562    +1343     

see 78 files with indirect coverage changes

@raunakab
Copy link
Contributor Author

raunakab commented Dec 5, 2024

Successful run, for reference:
https://github.com/Eventual-Inc/Daft/actions/runs/12171132350

@raunakab raunakab requested a review from colin-ho December 5, 2024 01:19
.github/ci-scripts/format_env_vars.py Show resolved Hide resolved
.github/ci-scripts/read_inline_metadata.py Show resolved Hide resolved
.github/ci-scripts/format_env_vars.py Show resolved Hide resolved
.github/ci-scripts/templatize_ray_config.py Outdated Show resolved Hide resolved
@raunakab raunakab enabled auto-merge (squash) December 5, 2024 17:49
@raunakab raunakab merged commit c2abed8 into main Dec 5, 2024
44 checks passed
@raunakab raunakab deleted the feat/shuffle-testing branch December 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants