Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(swordfish): Parallel expression evaluation #3593

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Merge branch main into colin/par-eval-expr

bcd8887
Select commit
Loading
Failed to load commit list.
Open

perf(swordfish): Parallel expression evaluation #3593

Merge branch main into colin/par-eval-expr
bcd8887
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

77.93% (+0.01%) compared to bae106c

View this Pull Request on Codecov

77.93% (+0.01%) compared to bae106c

Details

Codecov Report

Attention: Patch coverage is 92.34973% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (bae106c) to head (bcd8887).

Files with missing lines Patch % Lines
src/daft-dsl/src/expr/mod.rs 68.00% 8 Missing ⚠️
...ft-local-execution/src/intermediate_ops/project.rs 92.00% 4 Missing ⚠️
src/daft-local-execution/src/run.rs 91.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3593      +/-   ##
==========================================
+ Coverage   77.91%   77.93%   +0.01%     
==========================================
  Files         727      727              
  Lines       91129    91588     +459     
==========================================
+ Hits        71007    71379     +372     
- Misses      20122    20209      +87     
Files with missing lines Coverage Δ
src/daft-local-execution/src/channel.rs 98.14% <100.00%> (-0.10%) ⬇️
src/daft-local-execution/src/dispatcher.rs 93.52% <100.00%> (ø)
...-execution/src/intermediate_ops/intermediate_op.rs 83.33% <100.00%> (+0.66%) ⬆️
src/daft-local-execution/src/pipeline.rs 90.73% <100.00%> (+0.06%) ⬆️
src/daft-local-execution/src/runtime_stats.rs 67.17% <100.00%> (-0.74%) ⬇️
...rc/daft-local-execution/src/sinks/blocking_sink.rs 85.15% <100.00%> (ø)
...c/daft-local-execution/src/sinks/streaming_sink.rs 82.01% <100.00%> (ø)
src/daft-local-execution/src/sources/source.rs 58.44% <100.00%> (ø)
...rc/daft-micropartition/src/ops/eval_expressions.rs 97.77% <100.00%> (+0.76%) ⬆️
src/daft-table/src/lib.rs 84.72% <100.00%> (+0.97%) ⬆️
... and 3 more

... and 11 files with indirect coverage changes