feat: Overwrite partitions mode #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3687 will improve performances by 42.87%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3687 +/- ##
==========================================
+ Coverage 77.79% 77.94% +0.14%
==========================================
Files 729 725 -4
Lines 90408 90967 +559
==========================================
+ Hits 70335 70904 +569
+ Misses 20073 20063 -10
|
colin-ho
commented
Jan 16, 2025
added 2 commits
January 16, 2025 17:49
colin-ho
commented
Jan 17, 2025
Comment on lines
+378
to
+390
| all_file_paths = [] | ||
| if overwrite_partitions: | ||
| # Get all files in ONLY the directories that were written to. | ||
|
|
||
| written_dirs = set(str(pathlib.Path(path).parent) for path in written_file_paths.to_pylist()) | ||
| for dir in written_dirs: | ||
| file_selector = pafs.FileSelector(dir, recursive=True) | ||
| try: | ||
| all_file_paths.extend( | ||
| [info.path for info in fs.get_file_info(file_selector) if info.type == pafs.FileType.File] | ||
| ) | ||
| except FileNotFoundError: | ||
| continue |
There was a problem hiding this comment.
@desmondcheongzx new implementation ready for review, where we only look for files to delete IF they are in the partition directories.
desmondcheongzx
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1768
Overwrite-partitions mode will only overwrite files in the partition directories that were written into as part of the write operation. E.g. partition "A" will be overwritten if and only if partition "A" was written into.
This PR also refactors the test code a bit.