Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): sql #3696

Merged
merged 5 commits into from
Jan 17, 2025

fix bad merge

20704df
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): sql #3696

fix bad merge
20704df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 1s

77.06% (-0.82%) compared to beae462

View this Pull Request on Codecov

77.06% (-0.82%) compared to beae462

Details

Codecov Report

Attention: Patch coverage is 83.83838% with 32 lines in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (beae462) to head (20704df).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-connect/src/execute.rs 83.19% 20 Missing ⚠️
src/daft-catalog/src/lib.rs 78.26% 5 Missing ⚠️
src/daft-connect/src/spark_analyzer.rs 87.50% 4 Missing ⚠️
src/daft-connect/src/connect_service.rs 77.77% 2 Missing ⚠️
src/daft-catalog/src/python.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3696      +/-   ##
==========================================
- Coverage   77.87%   77.06%   -0.82%     
==========================================
  Files         721      720       -1     
  Lines       90505    91795    +1290     
==========================================
+ Hits        70479    70738     +259     
- Misses      20026    21057    +1031     
Files with missing lines Coverage Δ
daft/catalog/__init__.py 30.55% <ø> (ø)
src/daft-catalog/python-catalog/src/python.rs 4.44% <ø> (ø)
src/daft-connect/src/session.rs 100.00% <100.00%> (ø)
src/daft-sql/src/lib.rs 100.00% <ø> (ø)
src/daft-sql/src/planner.rs 75.10% <100.00%> (-0.08%) ⬇️
src/daft-sql/src/python.rs 50.74% <100.00%> (+3.97%) ⬆️
src/daft-catalog/src/python.rs 25.80% <0.00%> (ø)
src/daft-connect/src/connect_service.rs 58.65% <77.77%> (+2.33%) ⬆️
src/daft-connect/src/spark_analyzer.rs 72.28% <87.50%> (+0.83%) ⬆️
src/daft-catalog/src/lib.rs 69.29% <78.26%> (-1.00%) ⬇️
... and 1 more

... and 54 files with indirect coverage changes