Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): make micropartition streamable over tables #3709

Merged
merged 1 commit into from
Jan 21, 2025

feat: make micropartition streamable over tables

23f0958
Select commit
Loading
Failed to load commit list.
Merged

feat(core): make micropartition streamable over tables #3709

feat: make micropartition streamable over tables
23f0958
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

77.74% (-0.21%) compared to 6b302af

View this Pull Request on Codecov

77.74% (-0.21%) compared to 6b302af

Details

Codecov Report

Attention: Patch coverage is 70.58824% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.74%. Comparing base (6b302af) to head (23f0958).

Files with missing lines Patch % Lines
src/daft-micropartition/src/micropartition.rs 66.66% 22 Missing ⚠️
src/daft-table/src/lib.rs 52.94% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3709      +/-   ##
==========================================
- Coverage   77.94%   77.74%   -0.21%     
==========================================
  Files         725      725              
  Lines       90952    91467     +515     
==========================================
+ Hits        70895    71110     +215     
- Misses      20057    20357     +300     
Files with missing lines Coverage Δ
src/daft-connect/src/execute.rs 84.15% <100.00%> (ø)
src/daft-table/src/ops/explode.rs 87.67% <100.00%> (ø)
src/daft-table/src/ops/joins/hash_join.rs 90.82% <100.00%> (+0.05%) ⬆️
src/daft-table/src/ops/joins/mod.rs 91.32% <100.00%> (+0.10%) ⬆️
src/daft-table/src/ops/unpivot.rs 94.00% <100.00%> (+0.52%) ⬆️
src/daft-table/src/lib.rs 84.14% <52.94%> (+0.40%) ⬆️
src/daft-micropartition/src/micropartition.rs 89.28% <66.66%> (-1.64%) ⬇️

... and 15 files with indirect coverage changes