refactor: remove eyre from daft-connect

[universalmind303]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging #3719 will degrade performances by 10.25%

_{Comparing universalmind303:connect-error-handling (b672f7a) with main (98a5589)}

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	test_count[1 Small File]	3.6 ms	4 ms	-10.25%
⚡	test_iter_rows_first_row[100 Small Files]	262.5 ms	165.3 ms	+58.76%

[codecov]

Codecov Report

Attention: Patch coverage is 35.41667% with 186 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (bae106c) to head (b672f7a).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/daft-connect/src/error.rs	6.25%	60 Missing ⚠️
src/daft-connect/src/spark_analyzer.rs	41.75%	53 Missing ⚠️
src/daft-connect/src/display.rs	18.42%	31 Missing ⚠️
src/daft-connect/src/spark_analyzer/datatype.rs	5.00%	19 Missing ⚠️
src/daft-connect/src/spark_analyzer/literal.rs	10.00%	9 Missing ⚠️
src/daft-connect/src/functions/core.rs	50.00%	6 Missing ⚠️
src/daft-connect/src/connect_service.rs	0.00%	4 Missing ⚠️
src/daft-connect/src/util.rs	70.00%	3 Missing ⚠️
src/daft-connect/src/execute.rs	96.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3719      +/-   ##
==========================================
- Coverage   77.91%   77.86%   -0.05%     
==========================================
  Files         727      728       +1     
  Lines       91129    91269     +140     
==========================================
+ Hits        71007    71071      +64     
- Misses      20122    20198      +76     

Files with missing lines	Coverage Δ
src/daft-connect/src/functions.rs	100.00% <ø> (ø)
src/daft-connect/src/lib.rs	94.44% <100.00%> (+1.90%)	⬆️
src/daft-connect/src/response_builder.rs	100.00% <100.00%> (ø)
src/daft-connect/src/execute.rs	85.91% <96.00%> (+2.52%)	⬆️
src/daft-connect/src/util.rs	73.91% <70.00%> (-3.36%)	⬇️
src/daft-connect/src/connect_service.rs	59.32% <0.00%> (+0.66%)	⬆️
src/daft-connect/src/functions/core.rs	90.27% <50.00%> (-5.38%)	⬇️
src/daft-connect/src/spark_analyzer/literal.rs	18.18% <10.00%> (ø)
src/daft-connect/src/spark_analyzer/datatype.rs	12.24% <5.00%> (+0.32%)	⬆️
src/daft-connect/src/display.rs	54.94% <18.42%> (+0.50%)	⬆️
... and 2 more

... and 12 files with indirect coverage changes

[raunakab]

Looks good! Just some minor "stylistic" nits.

[raunakab]

Did we run the linter on this commit? Usually it catches and removes empty lines...

[universalmind303]

the formatter/linter is kinda bad at picking up newlines and such when using macros

[raunakab]

We have lots of impl From<X> for ConnectError { .. } in this file. May be worth considering implementing a derive macro in a future PR...