Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LiteralValue::Int8 and Int16 #3736

Merged

Conversation

ugoa
Copy link
Contributor

@ugoa ugoa commented Jan 29, 2025

closes #3365

@github-actions github-actions bot added the feat label Jan 29, 2025
@ugoa ugoa changed the title feat: add literalvalue int8 int16 feat: add LiteralValue::Int8 and Int16 Jan 29, 2025
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #3736 will improve performances by 47.91%

Comparing ugoa:DAFT-3365-add-literalvalue-int8-int16 (5613e6e) with main (a8d63dd)

Summary

⚡ 2 improvements
✅ 25 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_count[1 Small File] 3.9 ms 3.4 ms +16.73%
test_show[100 Small Files] 23.5 ms 15.9 ms +47.91%

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 36.58537% with 52 lines in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (a8d63dd) to head (5613e6e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-dsl/src/lit.rs 41.09% 43 Missing ⚠️
src/daft-sql/src/modules/numeric.rs 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
- Coverage   77.58%   77.55%   -0.04%     
==========================================
  Files         729      729              
  Lines       92035    92116      +81     
==========================================
+ Hits        71409    71440      +31     
- Misses      20626    20676      +50     
Files with missing lines Coverage Δ
src/daft-algebra/src/simplify.rs 77.34% <ø> (ø)
src/daft-sql/src/modules/numeric.rs 78.43% <0.00%> (-4.91%) ⬇️
src/daft-dsl/src/lit.rs 55.42% <41.09%> (-2.82%) ⬇️

... and 1 file with indirect coverage changes

@universalmind303 universalmind303 self-requested a review January 29, 2025 16:15
Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks @ugoa

@universalmind303 universalmind303 merged commit de5acf5 into Eventual-Inc:main Jan 29, 2025
41 of 42 checks passed
@ugoa
Copy link
Contributor Author

ugoa commented Jan 30, 2025

Oh wow, thanks for accepting the PR!

@ugoa ugoa deleted the DAFT-3365-add-literalvalue-int8-int16 branch January 31, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add LiteralValue::Int8
2 participants