Skip to content

Commit

Permalink
Detect launcher failure in the batch scheduler executors. Somehow this
Browse files Browse the repository at this point in the history
was only done in the local executor.
  • Loading branch information
hategan committed Feb 7, 2024
1 parent 391eb6b commit ed0fc92
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/psij/executors/batch/batch_scheduler_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,11 @@ def _read_aux_files(self, job: Job, status: JobStatus) -> None:
if status.message is None:
# only read output from submit script if another error message is not
# already present
status.message = self._read_aux_file(job, '.out')
out = self._read_aux_file(job, '.out')
if out:
launcher = self._get_launcher_from_job(job)
if launcher.is_launcher_failure(out):
status.message = launcher.get_launcher_failure_message(out)

Check warning on line 574 in src/psij/executors/batch/batch_scheduler_executor.py

View check run for this annotation

Codecov / codecov/patch

src/psij/executors/batch/batch_scheduler_executor.py#L574

Added line #L574 was not covered by tests
logger.debug('Output from launcher: %s', status.message)
else:
self._delete_aux_file(job, '.out')
Expand Down

0 comments on commit ed0fc92

Please sign in to comment.