Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinxcontrib-applehelp 1.0.8 added a requirement for Sphinx 5.0, which #438

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Jan 15, 2024

breaks Sphinx 4.5 who doesn't pin the dep to something compatible with it.

It's even more silly because we don't generate applehelp output.

breaks Sphinx 4.5 who doesn't pin the dep to something compatible with it.

It's even more silly because we don't generate applehelp output.
Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's what we need ¯\_(ツ)_/¯

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92525d9) 74.98% compared to head (23dcc95) 74.98%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   74.98%   74.98%           
=======================================
  Files          92       92           
  Lines        3794     3794           
=======================================
  Hits         2845     2845           
  Misses        949      949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

now (many of these plugins have required 5.0 for years) remains unclear.
@hategan hategan merged commit 6217874 into main Jan 15, 2024
11 checks passed
@hategan hategan deleted the fix_web_build branch January 15, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants