Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resource specs to PBS executor, which were somehow missing. #439

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Jan 15, 2024

Also split PBS executor into pbs_classic (the one using :ppn to specify processes per node) and the modern pbspro/openpbs (using select=:ncpus=).

Fixes #434

Also split PBS executor into pbs_classic (the one using `:ppn` to specify
processes per node) and the modern pbspro/openpbs (using `select=:ncpus=`).
@hategan hategan requested a review from andre-merzky January 15, 2024 20:51
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9e6abb9) 74.98% compared to head (5706789) 75.28%.
Report is 9 commits behind head on main.

Files Patch % Lines
src/psij/executors/batch/pbs.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   74.98%   75.28%   +0.29%     
==========================================
  Files          92       94       +2     
  Lines        3794     3925     +131     
==========================================
+ Hits         2845     2955     +110     
- Misses        949      970      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not do a thorough review but also don't want to hold this up any longer. From what I have seen this looks sensible and clean. This will need to be tested on the respective schedulers - but I think a merge will only make tests more likely - so IMHO this is good to go.

@hategan hategan merged commit 391eb6b into main Feb 5, 2024
13 checks passed
@hategan hategan deleted the pbs_fixes branch February 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to get ResourceSpecV1 working with PBS
2 participants