Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the submit command fails, log the batch script at DEBUG level to #440

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Jan 27, 2024

aid in debugging.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6217874) 74.94% compared to head (5a8ce2b) 74.86%.

Files Patch % Lines
...c/psij/executors/batch/batch_scheduler_executor.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   74.94%   74.86%   -0.08%     
==========================================
  Files          92       92              
  Lines        3804     3808       +4     
==========================================
  Hits         2851     2851              
- Misses        953      957       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that..

@hategan hategan merged commit 58ff5ec into main Feb 5, 2024
13 of 15 checks passed
@hategan hategan deleted the log_submit_script_on_submit_error branch February 5, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants