Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to specify test filters for custom attributes. #443

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Feb 2, 2024

The motivation here is that, on Perlmutter, it's a wise idea to run most tests on shared nodes (since we don't want to burn too fast through a small allocation). However, some tests, such as tests that verify that multi-node jobs run on multiple nodes, will fail since the shared node mode (--qos=shared) does not allow for multi-node jobs. So there needs to be a way to use a different --qos parameter for certain tests.

@hategan hategan requested a review from andre-merzky February 2, 2024 22:18
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (6217874) 74.94% compared to head (f244906) 74.47%.

Files Patch % Lines
tests/conftest.py 37.03% 17 Missing ⚠️
tests/ci_runner.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   74.94%   74.47%   -0.47%     
==========================================
  Files          92       92              
  Lines        3804     3844      +40     
==========================================
+ Hits         2851     2863      +12     
- Misses        953      981      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@hategan hategan merged commit 991a6a0 into main Feb 5, 2024
11 of 13 checks passed
@hategan hategan deleted the per_test_custom_attrs branch February 5, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants