Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect launcher failure in the batch scheduler executors. Somehow this #444

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Feb 7, 2024

was only done in the local executor.

@hategan hategan requested a review from andre-merzky February 7, 2024 03:16
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (391eb6b) 74.48% compared to head (ed0fc92) 74.48%.

Files Patch % Lines
...c/psij/executors/batch/batch_scheduler_executor.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   74.48%   74.48%           
=======================================
  Files          94       94           
  Lines        3868     3872    +4     
=======================================
+ Hits         2881     2884    +3     
- Misses        987      988    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense of course...

@hategan hategan merged commit a7a1256 into main Feb 7, 2024
15 checks passed
@hategan hategan deleted the process_launcher_msg branch February 7, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants