Fix thread "leak" #502
Merged
Fix thread "leak" #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ular references and shut down the QueuePollThread when the executor is garbage collected.
| with self._jobs_lock: | ||
| if len(self._jobs) == 0: | ||
| return | ||
| jobs_copy = dict(self._jobs) | ||
| logger.info('Polling for %s jobs', len(jobs_copy)) | ||
| try: | ||
| out = self.executor._run_command(self.executor.get_status_command(jobs_copy.keys())) | ||
| if exec: |
There was a problem hiding this comment.
if exec is not needed, that is checked above.
There was a problem hiding this comment.
Ah, thank you. Will issue a small PR for that.
No worries. I thought you were away. Glad you took a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #501 by replacing the executor property of _QueuePollThread by weakref and shutting down the thread when
the executor is collected. The weak ref is necessary to avoid a reference loop which would prevent a
__del__based solution from working.