Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github CI: remove tags from container names #2728

Merged
merged 1 commit into from
Aug 3, 2023
Merged

github CI: remove tags from container names #2728

merged 1 commit into from
Aug 3, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 1, 2023

No description provided.

@ghost
Copy link

ghost commented Aug 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2728 (9f97144) into main (901e8ba) will increase coverage by 0.01%.
Report is 48 commits behind head on main.
The diff coverage is 83.33%.

❗ Current head 9f97144 differs from pull request most recent head 9908f75. Consider uploading reports for the commit 9908f75 to get more accurate results

@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
+ Coverage   63.89%   63.91%   +0.01%     
==========================================
  Files         103      103              
  Lines       22313    22313              
  Branches    10799    10806       +7     
==========================================
+ Hits        14258    14261       +3     
+ Misses       5830     5828       -2     
+ Partials     2225     2224       -1     
Files Changed Coverage Δ
include/exiv2/value.hpp 84.90% <ø> (-0.22%) ⬇️
src/canonmn_int.cpp 73.17% <ø> (+0.29%) ⬆️
src/casiomn_int.cpp 6.45% <ø> (ø)
src/fujimn_int.cpp 39.62% <ø> (ø)
src/makernote_int.cpp 65.91% <ø> (ø)
src/nikonmn_int.cpp 61.20% <ø> (ø)
src/olympusmn_int.cpp 45.39% <ø> (ø)
src/panasonicmn_int.cpp 52.58% <ø> (ø)
src/pgfimage.cpp 42.76% <0.00%> (ø)
src/preview.cpp 45.02% <ø> (ø)
... and 22 more

@neheb neheb force-pushed the cii branch 2 times, most recently from d59c2ee to 52e7928 Compare August 1, 2023 02:55
@neheb
Copy link
Collaborator Author

neheb commented Aug 2, 2023

@Ryanf55 see last commit as an example of how to try to fix this garbage with this bug in place. Way too much code needs to be written(missing overridden destructors, same needs to be done with static const, etc...).

@Ryanf55
Copy link
Contributor

Ryanf55 commented Aug 3, 2023

@Ryanf55 see last commit as an example of how to try to fix this garbage with this bug in place. Way too much code needs to be written(missing overridden destructors, same needs to be done with static const, etc...).

Not clear - are you asking me to fix it everywhere? I don't have time other than the bare minimum. We're using Linux with 3.27 CMake and it compiles fine with all the patches I put in, so that's about all I can support here.

Just a note = If the link error was caused by upgrading CMake, you could set the corresponding CMake policy to preserve <=3.26 behavior, if there's a policy for it. That would affect the whole build, and buy you some time.

@neheb
Copy link
Collaborator Author

neheb commented Aug 3, 2023

No I was pointing out that fixing it this way is impractical. The other PR has a normal fix.

Best to be latest.

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb changed the title ci: remove old hacks no longer needed github CI: remove tags from container names Aug 3, 2023
@neheb neheb requested a review from kmilos August 3, 2023 17:06
@neheb neheb marked this pull request as ready for review August 3, 2023 21:32
@neheb neheb merged commit 43ffc61 into Exiv2:main Aug 3, 2023
105 checks passed
@neheb neheb deleted the cii branch August 3, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants