remove Exif.Photo.SceneCaptureType from easyaccess group sceneMode #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it is included in easyaccess group sceneCaptureType
Codecov Report
@@ Coverage Diff @@
## main #2758 +/- ##
=======================================
Coverage 63.91% 63.91%
=======================================
Files 103 103
Lines 22323 22323
Branches 10812 10812
=======================================
Hits 14268 14268
Misses 5832 5832
Partials 2223 2223
|
neheb
approved these changes
Sep 26, 2023
norbertwg
deleted the
easyaccess-remove-SceneCaptureType-from-sceneMode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exif.Photo.SceneCaptureType is contained in two easyaccess groups, sceneCaptureType and sceneMode. It is the only tag contained in two groups. When it was added to sceneMode with commit 482cd93 in June 2010, it was already included in sceneCaptureType. So it seems to me, that at that point of time it was not remembered, that it was already in easyaccess. So for me it sounds logical, to have this tag only in sceneCaptureType and to remove it from sceneMode.