install exiv2 cmake module in LIBDIR #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
installed cmake module contains arch dependent library description. It should be installed not in DATADIR but in LIBDIR. Signed-off-by: Tomasz Kłoczko <[email protected]>
|
CMake will look for these files in multiple locations, so not an error per se, but I guess this might be a matter of preference... Not sure why it was changed though, I think it was LIBDIR before 0.28.1? |
In 0.28.0 was in libdir. |
|
Go for it. This was a mistake on my end; seems like a majority are installed in On ubuntu 22: |
Ryanf55
approved these changes
Nov 6, 2023
neheb
approved these changes
Nov 6, 2023
|
Thank you 👍 |
|
@mergify backport 0.28.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installed cmake module contains arch dependent library description.
It should be installed not in DATADIR but in LIBDIR.