Add search input to mobile search page(with fixed performance) #56326

SzymczakJ · 2025-02-04T11:25:36Z

Explanation of Change

This PR is mainly about redesigning Search Page but I also made a pretty big refactor and improved performance of Search Page mobile header animation.
These are the design changes:

on SearchPage full screen, the SearchRouterInput is always visible, previously the SearchRouterInput was hidden when we were in "canned search" state.

on mobile SearchPage, we remove the button that navigates to SearchRouter
instead of that we put SearchRouterInput in place where SearchTypeMenuNarrow was, focusing this input is making SearchRouterList visible.

on mobile SearchPage user can still open type menu modal by pressing the button next to SearchRouterInput

These are refactor changes:

Refactor of SearchPageBottomTab.tsx so that it has one render for narrow screen and one render for full screen, for better readability.
Delete SearchTypeMenuNarrow.tsx and decuple it's logic from SearchTypeMenu.tsx, now this logic lives in SearchTypeMenuPopover.tsx with the common parts of SearchTypeMenuPopover and SearchTypeMenu put into SearchUIUtils.
Delete SearchSelectionModeHeader.tsx as it added unnecessary layer that was confusing.

Fixed Issues

$ #52317
$ #55828
PROPOSAL:

Tests

On full screen SearchPage make sure that SearchRouterInput displays in every case.
Test if clicking on canned searches and saved searches works as expected.
Test if writing into SearchRouterInput works as expected.
On mobile, test scrolling SearchPage list and SearchRouterList(after focusing SearchRouterInput).
Test SearchRouterList, if it works as expected(if clicking on recent searches items works as expected etc.).
Test if advanced filters button works as expected.
Test if type menu button(next to SearchRouterInput) works as expected and it's possible to go to canned item or saved item.

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This reverts commit 66d4222.

melvin-bot · 2025-02-04T11:25:40Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…page

melvin-bot · 2025-02-05T15:14:34Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-02-05T17:11:23Z

🚧 @luacmartins has triggered a test build. You can view the workflow run here.

shawnborton · 2025-02-05T19:09:20Z

Hmm this feels very sluggish to me. It seems like there is quite the delay for the input to animate. And then when you close the input, all of the avatars flash back in as well. Can we try to make this one a bit smoother?

ScreenRecording_02-05-2025.11-04-52_1.MP4

Can you also check and make sure the placeholder text here is using our correct textSupporting color? Thanks!

luacmartins · 2025-02-05T19:56:01Z

@IuliiaHerets could you please run the test steps from this issue using the builds here. Hopefully that issue is fixed in this build

sobitneupane · 2025-02-06T04:22:07Z

@ikevin127 All yours as you were reviewer in the previous reverted PR. Please let me know if you won't be available to review the PR.

ikevin127 · 2025-02-06T04:28:02Z

@sobitneupane Thanks, I'll start working on the checklist, making sure to test all issues encountered last time which led to the revert 👍

ikevin127 · 2025-02-06T04:28:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

Kicu

Went over the PR, it gets quite complicated with all the changes of components :/ but in general great work on this

Kicu · 2025-02-06T07:32:18Z

src/styles/index.ts

+            flex: 1,
+        },
+
+        typePopoverButtonStyle: {


I know that we have a preference to use style props/consts but I think if it's just a class for 1 line of styles, then maybe it's better to just inline theme.sidebarHover in the component that it's used?

Kicu · 2025-02-06T07:40:10Z

src/components/TextInput/BaseTextInput/index.tsx

@@ -76,6 +76,7 @@ function BaseTextInput(
        contentWidth,
        loadingSpinnerStyle,
        uncontrolled = false,
+        placeholderTextColor,


another prop 😭 😭 😭

Kicu · 2025-02-06T07:42:19Z

src/libs/CardUtils.ts

@@ -98,7 +98,7 @@ function isCardHiddenFromSearch(card: Card) {
    return !card?.nameValuePairs?.isVirtual && CONST.EXPENSIFY_CARD.HIDDEN_FROM_SEARCH_STATES.includes(card.state ?? 0);
 }

-function mergeCardListWithWorkspaceFeeds(workspaceFeeds: Record<string, WorkspaceCardsList | undefined>, cardList = allCards, shouldExcludeCardHiddenFromSearch = false) {
+function mergeCardListWithWorkspaceFeeds(workspaceFeeds: Record<string, WorkspaceCardsList | undefined> | undefined, cardList = allCards, shouldExcludeCardHiddenFromSearch = false) {


IMO it looks bad when the first argument can be undefined but there are other arguments after it. It is technically "correct" from the perspective of JS/TS but bad function design.

Can we revert the change? did you do it just to avoid creating empty objects in other places in Search code?

Kicu · 2025-02-06T07:44:16Z

src/libs/SearchUIUtils.ts

+            },
+        });
+    }
+    typeMenuItems.push({


Suggested change

typeMenuItems.push({

typeMenuItems.push({

Kicu · 2025-02-06T07:47:29Z

src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx

            return;
        }
+        textInputRef.current.blur();
+        // eslint-disable-next-line react-compiler/react-compiler
+        // eslint-disable-next-line react-hooks/exhaustive-deps


Suggested change

// eslint-disable-next-line react-hooks/exhaustive-deps

// eslint-disable-next-line react-compiler/react-compiler react-hooks/exhaustive-deps

1 line less ;)

Kicu · 2025-02-06T07:51:05Z

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx

@@ -63,12 +61,12 @@ function TopBar({breadcrumbLabel, activeWorkspaceID, shouldDisplaySearch = true,
                    </View>
                </View>
                {displaySignIn && <SignInButton />}
-                {shouldDisplayCancelSearch && (
+                {shouldDisplayCancel && (


NAB - reminder for me to discuss 1 thing about using shouldDisplayCancel + callback

…page

IuliiaHerets · 2025-02-06T14:23:45Z

@luacmartins Tester cannot repro the issue using mentioned builds

Screen_Recording_20250206_214923_New.Expensify.AdHoc.mp4

SzymczakJ · 2025-02-06T15:38:28Z

I've improved performance of the TextInput animation, tell me what do you think @shawnborton.
I've sqeezed as much as I could from it, but when we improve the overall performance of Reports page in future iterations, the animation will also become smoother. At the moment the animation might lag, when we focus the input right after navigating to Reports, just because rendering Reports page is so heavy and JS thread is busy for couple of seconds

github-actions · 2025-02-06T16:05:19Z

🚧 @luacmartins has triggered a test build. You can view the workflow run here.

luacmartins · 2025-02-06T16:05:29Z

I've kicked off an adhoc build

luacmartins · 2025-02-06T16:05:55Z

@luacmartins Tester cannot repro the issue using mentioned #56326 (comment)

Thanks @IuliiaHerets

dannymcclain · 2025-02-06T23:41:59Z

😕 I'm kinda with you, it really doesn't feel great.

dubielzyk-expensify · 2025-02-07T00:18:43Z

What's our easing on this animation? I wonder if it's jank or just animation timing weirdness?

ikevin127 · 2025-02-07T00:19:52Z

🚀 LGTM - Completed PR Reviewer Checklist ✅

Beside the tests mentioned in OP, I tested the following issues from last (reverted) PR:

✅ Android & iOS - Reports - Reports page is not opened instantly

iOS: Native

ios.mp4

Note: Minimal animation delay when focusing the input, expected as mentioned in #56326 (comment).
⚠️ Previous PR tutorial popover placement issue

This was fixed in the other PR but I noticed that on narrow layout devices the "Customize your search here!" popover. This happens on both mWeb and Native (iOS/Android), here's a video compared to current staging which proves that the issue is only present on this PR:

See videos

Android: mWeb (PR / Staging) iOS: mWeb (PR / Staging)

issue-mweb-ba.webm

issue-mweb-b-a.mp4

@luacmartins Let me know whether the above issue should be addressed and depending on your response I'll 🟢 Approve right away or await the fix and retest then Approve.

SzymczakJ · 2025-02-07T15:41:22Z

I've used other approach to our TextInput animation, right now we let the animation go first and after it's complete we change the state, that should make it smoother. Can you guys check it out @shawnborton @dubielzyk-expensify @dannymcclain?
On my end it runs with better performance.

shawnborton · 2025-02-07T17:56:47Z

I will run another test build for us.

github-actions · 2025-02-07T17:57:27Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

github-actions · 2025-02-07T18:23:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56326/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56326/NewExpensify.dmg	https://56326.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-02-07T18:24:20Z

Hmm no iOS... maybe we need to merge main?

…page

SzymczakJ · 2025-02-10T09:47:32Z

Merged main, can you try running build again? @shawnborton

github-actions · 2025-02-10T14:20:59Z

🚧 @dannymcclain has triggered a test build. You can view the workflow run here.

github-actions · 2025-02-10T14:46:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56326/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56326/NewExpensify.dmg	https://56326.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

SzymczakJ · 2025-02-10T16:01:29Z

I think something is broken with adhoc build workflow, because all of adhoc builds are failing since Friday. I've written about this on open-source.

shawnborton · 2025-02-10T20:40:25Z

Sounds good, keep us posted when you think we can run another test build so we can see how mobile feels.

luacmartins · 2025-02-10T22:19:24Z

@SzymczakJ we're running into some failing tests, e.g.

Error: src/components/Search/SearchAutocompleteInput.tsx(132,17): error TS2590: Expression produces a union type that is too complex to represent.

/home/runner/work/App/App/src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
Error:   6:[19](https://github.com/Expensify/App/actions/runs/13245788569/job/36971853810?pr=56326#step:4:20)  error  'runOnJS' is defined but never used           @typescript-eslint/no-unused-vars
Error:   6:28  error  'useAnimatedStyle' is defined but never used  @typescript-eslint/no-unused-vars
Error:   6:46  error  'useSharedValue' is defined but never used    @typescript-eslint/no-unused-vars
Error:   6:62  error  'withTiming' is defined but never used        @typescript-eslint/no-unused-vars

Let's fix those too.

I'll look into the failing iOS build

luacmartins · 2025-02-10T22:44:07Z

Hmm the build is succeeding locally. I'll try to delete caches and run it again.

github-actions · 2025-02-10T22:49:51Z

🚧 @luacmartins has triggered a test build. You can view the workflow run here.

luacmartins · 2025-02-10T23:08:54Z

That didn't work. Asked here since that PR is sus

github-actions · 2025-02-10T23:18:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56326/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56326/NewExpensify.dmg	https://56326.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…cused

SzymczakJ · 2025-02-11T17:23:23Z

I think the adhoc builds are working now, can you try to build and retest it? The mobile animation should be ready to test, I've just noticed a small bug on mWeb and I'm working on it.

luacmartins · 2025-02-11T19:28:28Z

Started a new build

github-actions · 2025-02-11T19:28:34Z

🚧 @luacmartins has triggered a test build. You can view the workflow run here.

github-actions · 2025-02-11T19:52:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56326/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56326/NewExpensify.dmg	https://56326.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

luacmartins · 2025-02-11T20:01:47Z

@SzymczakJ can you merge main? Maybe we need some changes from main to get adhoc builds working again

SzymczakJ added 2 commits January 31, 2025 12:26

Reapply "Redesign search to always show search input(mobile + desktop)."

74b209e

This reverts commit 66d4222.

fix performance of SearchPageHeader

58e6489

SzymczakJ added 3 commits February 4, 2025 14:10

Merge branch 'main' into @szymczak/add-search-input-to-mobile-search-…

aebd392

…page

fix bugs introduced by SearchBottomTab refactor

127c0f8

Merge branch 'main' into @szymczak/add-search-input-to-mobile-search-…

11ad336

…page

SzymczakJ marked this pull request as ready for review February 5, 2025 15:14

SzymczakJ requested review from a team as code owners February 5, 2025 15:14

melvin-bot bot requested a review from sobitneupane February 5, 2025 15:14

melvin-bot bot removed the request for review from a team February 5, 2025 15:14

luacmartins added the Ready To Build label Feb 5, 2025

This comment has been minimized.

Sign in to view

Kicu reviewed Feb 6, 2025

View reviewed changes

SzymczakJ added 2 commits February 6, 2025 15:15

fix PR comments

9bec74f

Merge branch 'main' into @szymczak/add-search-input-to-mobile-search-…

246df8f

…page

SzymczakJ added 2 commits February 6, 2025 15:26

add missing prop to SearchInputSelectionWrapper

0aba65f

improve performance of SearchInputWrapper margin animation

8a4b7c6

fix input focused style

131d73b

Merge branch 'main' into @szymczak/add-search-input-to-mobile-search-…

7592bd7

…page

change padding animation to layout animation

3c7389a

SzymczakJ added 4 commits February 11, 2025 10:51

fix typescript errors

d837db5

fix dissaprearing autocompleted keys when AutocompleteInput is not fo…

01c6a2a

…cused

fix PR comments

9d914e8

fix typescript

9765e74

	// eslint-disable-next-line react-hooks/exhaustive-deps
	// eslint-disable-next-line react-compiler/react-compiler react-hooks/exhaustive-deps

Add search input to mobile search page(with fixed performance) #56326

Are you sure you want to change the base?

Add search input to mobile search page(with fixed performance) #56326

Conversation

SzymczakJ commented Feb 4, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 4, 2025

melvin-bot bot commented Feb 5, 2025

github-actions bot commented Feb 5, 2025

This comment has been minimized.

shawnborton commented Feb 5, 2025

luacmartins commented Feb 5, 2025

sobitneupane commented Feb 6, 2025

ikevin127 commented Feb 6, 2025

ikevin127 commented Feb 6, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

Kicu left a comment

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

Kicu Feb 6, 2025

Choose a reason for hiding this comment

IuliiaHerets commented Feb 6, 2025

SzymczakJ commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

luacmartins commented Feb 6, 2025

luacmartins commented Feb 6, 2025

dannymcclain commented Feb 6, 2025

dubielzyk-expensify commented Feb 7, 2025

ikevin127 commented Feb 7, 2025

SzymczakJ commented Feb 7, 2025

shawnborton commented Feb 7, 2025

github-actions bot commented Feb 7, 2025

github-actions bot commented Feb 7, 2025

shawnborton commented Feb 7, 2025

SzymczakJ commented Feb 10, 2025 • edited Loading

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

SzymczakJ commented Feb 10, 2025 • edited Loading

shawnborton commented Feb 10, 2025

luacmartins commented Feb 10, 2025

luacmartins commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

luacmartins commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

SzymczakJ commented Feb 11, 2025

luacmartins commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

luacmartins commented Feb 11, 2025

SzymczakJ commented Feb 4, 2025 •

edited

Loading

ikevin127 commented Feb 6, 2025 •

edited

Loading

SzymczakJ commented Feb 10, 2025 •

edited

Loading

SzymczakJ commented Feb 10, 2025 •

edited

Loading