Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor index.js to utilize the class/extends js syntax over the older inherit syntax. Also updated the load.js to use a new THREE.TextureLoader over the depreciated Three.ImageUtils.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Did you test your solution?
Problem Description
Index.js was using ES5 inherits syntax.
Load.js was using THREE.ImageUtils, which has been depreciated.
Solution Description
Refactored TextGeometry in index.js to use the class/extends syntax (ES6 vs ES5). Refactoring allows for one less dependency.
Updating Load.js avoids using depreciated THREE.js ImageUtils.
Side Effects, Risks, Impact
I found no side effects or changes in testing, other than no longer getting a warning about using the now depreciated THREE.ImageUtils when running the npm test scripts.
Aditional comments:
Ran into this when I was playing around with updating THREE.js to a newer version in the dependencies. However, I decided against that for now (it looks like there is other discussion about whether or not to depend on three from within this package). Doing this change allows using the latest version of THREE (r128), otherwise, updating THREE results in the following error.
"Uncaught TypeError: Class constructor BufferGeometry cannot be invoked without 'new'"
Not sure if updating the dependencies is a priority (I left it out of this PR), but this would hopefully help speed line that process while doing nothing detrimental in the meantime.
Thanks for all your work on this! Only learned about MSDF a short while ago, and it's been fun playing around with it.