Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改写为es6语法,解决在新版Aframe框架中的报错 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JetsomMa
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Code style update
  • Refactor (refactoring or adding test which isn't a fix or add a feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build-related changes
  • [ * ] Other, please describe: change the code to ES6, solve Aframe error

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ * ] No

Did you test your solution?

  • [ * ] I lightly tested it in one browser
  • I deeply tested it in several browsers
  • I wrote tests around it (unit tests, integration tests, E2E tests)

Problem Description

在Aframe框架中有一个a-text组件用到了我们的代码,但是新版的aframe有了一些ES6特性,其与我们现在代码的写法不兼容,所以做出改变

Solution Description

将ES5的写法改为了ES6语法糖的class写法

Side Effects, Risks, Impact

  • N/A

只在Aframe框架中测试通过,对其他框架的副作用,目前尚不清楚

Aditional comments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant